* [BUG] macmodes.c in 2.3.99-pre3-pre8
@ 2000-04-01 21:10 Martin Costabel
2000-04-02 19:15 ` Ani Joshi
0 siblings, 1 reply; 2+ messages in thread
From: Martin Costabel @ 2000-04-01 21:10 UTC (permalink / raw)
To: linuxppc-dev@lists.linuxppc.org
Starting from about a week ago, the 2.3.99 bitkeeper kernels screw up
the colors in Xpmac, making it unusable (8-bit color, valkyriefb
driver). XF_FBDev is working fine.
I tracked this down to what I think is a typo in the big code crossover
from offb.c to macmodes.c. In any case, the following patch fixes the
problem for me:
-- drivers/video/macmodes.c.ori Sat Mar 25 08:25:22 2000
+++ drivers/video/macmodes.c Sat Apr 1 22:08:08 2000
@@ -271,7 +271,7 @@
n = n_entries - i;
if (n > 16)
n = 16;
- palette_cmap.start = 1;
+ palette_cmap.start = i;
palette_cmap.len = n;
for (j = 0; j < n; j++) {
--
Martin
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [BUG] macmodes.c in 2.3.99-pre3-pre8
2000-04-01 21:10 [BUG] macmodes.c in 2.3.99-pre3-pre8 Martin Costabel
@ 2000-04-02 19:15 ` Ani Joshi
0 siblings, 0 replies; 2+ messages in thread
From: Ani Joshi @ 2000-04-02 19:15 UTC (permalink / raw)
To: Martin Costabel; +Cc: linuxppc-dev@lists.linuxppc.org
oops, thanks for spotting that. You're right, i missed that in the code
migration.
thanks,
ani
On Sat, 1 Apr 2000, Martin Costabel wrote:
>
> Starting from about a week ago, the 2.3.99 bitkeeper kernels screw up
> the colors in Xpmac, making it unusable (8-bit color, valkyriefb
> driver). XF_FBDev is working fine.
>
> I tracked this down to what I think is a typo in the big code crossover
> from offb.c to macmodes.c. In any case, the following patch fixes the
> problem for me:
>
> -- drivers/video/macmodes.c.ori Sat Mar 25 08:25:22 2000
> +++ drivers/video/macmodes.c Sat Apr 1 22:08:08 2000
> @@ -271,7 +271,7 @@
> n = n_entries - i;
> if (n > 16)
> n = 16;
> - palette_cmap.start = 1;
> + palette_cmap.start = i;
> palette_cmap.len = n;
>
> for (j = 0; j < n; j++) {
>
> --
> Martin
>
>
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2000-04-02 19:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2000-04-01 21:10 [BUG] macmodes.c in 2.3.99-pre3-pre8 Martin Costabel
2000-04-02 19:15 ` Ani Joshi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).