From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ysWgh6GKdzF06C for ; Thu, 7 Dec 2017 08:18:40 +1100 (AEDT) Subject: [PATCH 2/3] tty/serial/ucc_uart: Improve a size determination in ucc_uart_probe() From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Timur Tabi Cc: LKML , kernel-janitors@vger.kernel.org References: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Message-ID: <38dd53cc-f7e8-57b9-bd0f-0946c787ac2e@users.sourceforge.net> Date: Wed, 6 Dec 2017 22:12:39 +0100 MIME-Version: 1.0 In-Reply-To: <5c6d363d-398b-4695-78c3-33b9e8dbffa3@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Markus Elfring Date: Wed, 6 Dec 2017 21:45:32 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/ucc_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index 48364f0eba72..a9ce652899aa 100644 --- a/drivers/tty/serial/ucc_uart.c +++ b/drivers/tty/serial/ucc_uart.c @@ -1253,7 +1253,7 @@ static int ucc_uart_probe(struct platform_device *ofdev) } } - qe_port = kzalloc(sizeof(struct uart_qe_port), GFP_KERNEL); + qe_port = kzalloc(sizeof(*qe_port), GFP_KERNEL); if (!qe_port) return -ENOMEM; -- 2.15.1