Re: PATCH 2.3.99.7.5: update for clgenfb fbdev driver

Re: PATCH 2.3.99.7.5: update for clgenfb fbdev driver

[Geert Uytterhoeven]

On Fri, 5 May 2000, Jeff Garzik wrote:
> updates my cirrus logic fbdev driver with a few cleanups, fix 0xA0000
> bug (note to alan), module and PCI cleanups, ...

Since clgen_of_init() is exactly the same as clgenfb_init(), and since clgenfb
uses PCI resource management, can't we simply get rid of the OF specific stuff
in clgenfb?

Can someone please test this by disabling Offb (CONFIG_FB_OF=n) and seeing
whether everything still works fine? Thanks!

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Linux/{m68k~Amiga,PPC~CHRP} -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: PATCH 2.3.99.7.5: update for clgenfb fbdev driver

[Jeff Garzik]

Geert Uytterhoeven wrote:
>
> On Fri, 5 May 2000, Jeff Garzik wrote:
> > updates my cirrus logic fbdev driver with a few cleanups, fix 0xA0000
> > bug (note to alan), module and PCI cleanups, ...
>
> Since clgen_of_init() is exactly the same as clgenfb_init(), and since clgenfb
> uses PCI resource management, can't we simply get rid of the OF specific stuff
> in clgenfb?
>
> Can someone please test this by disabling Offb (CONFIG_FB_OF=n) and seeing
> whether everything still works fine? Thanks!

If I can find someone to test, it can definitely be removed.  Thanks for
noticing..

	Jeff



--
Jeff Garzik              | ILOVEYOU, Linux.
Building 1024            |
MandrakeSoft, Inc.       |

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: PATCH 2.3.99.7.5: update for clgenfb fbdev driver

[Kazunori Aoshima]

Hi,

Return for :
From: Geert Uytterhoeven <geert@linux-m68k.org>
on " Re: PATCH 2.3.99.7.5: update for clgenfb fbdev driver "
date: Fri, 5 May 2000 13:38:26 +0200 (CEST) >>>

> On Fri, 5 May 2000, Jeff Garzik wrote:
> > updates my cirrus logic fbdev driver with a few cleanups, fix 0xA0000
> > bug (note to alan), module and PCI cleanups, ...
>
> Since clgen_of_init() is exactly the same as clgenfb_init(), and since clgenfb
> uses PCI resource management, can't we simply get rid of the OF specific stuff
> in clgenfb?
>
> Can someone please test this by disabling Offb (CONFIG_FB_OF=n) and seeing
> whether everything still works fine? Thanks!

I would like to test it on my PowerStack.

The test need to test two things.

1. Add clgenfb (Version? I have 1.9.4.4 .) patch on newest
   kernel 2.3.99.7.5 .
2. CONFIG_FB_OF=n and CONFIG_FB_CLGEN=y needs on the config file.

Is that so?

Best regards.
----------------------
Kaz Aoshima = Editor of the PReP station
Material development, Faculty of engineering,
Tohoku University, Japan
E-mail:aoshimak@mail.cc.tohoku.ac.jp
#I would appreciate if you could give me suggestions
 for my impolite English expressions.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: PATCH 2.3.99.7.5: update for clgenfb fbdev driver

[Geert Uytterhoeven]

On Sat, 6 May 2000, Kazunori Aoshima wrote:
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> on " Re: PATCH 2.3.99.7.5: update for clgenfb fbdev driver "
> date: Fri, 5 May 2000 13:38:26 +0200 (CEST) >>>
>
> > On Fri, 5 May 2000, Jeff Garzik wrote:
> > > updates my cirrus logic fbdev driver with a few cleanups, fix 0xA0000
> > > bug (note to alan), module and PCI cleanups, ...
> >
> > Since clgen_of_init() is exactly the same as clgenfb_init(), and since clgenfb
> > uses PCI resource management, can't we simply get rid of the OF specific stuff
> > in clgenfb?
> >
> > Can someone please test this by disabling Offb (CONFIG_FB_OF=n) and seeing
> > whether everything still works fine? Thanks!
>
> I would like to test it on my PowerStack.
>
> The test need to test two things.
>
> 1. Add clgenfb (Version? I have 1.9.4.4 .) patch on newest
>    kernel 2.3.99.7.5 .

You best use clgenfb from 2.3.99-pre7-6, I think.

> 2. CONFIG_FB_OF=n and CONFIG_FB_CLGEN=y needs on the config file.

Yes, that should do it.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Linux/{m68k~Amiga,PPC~CHRP} -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: [linux-fbdev] Re: PATCH 2.3.99.7.5: update for clgenfb fbdev driver

[Adam C Powell IV]

Geert Uytterhoeven wrote:

> On Fri, 5 May 2000, Jeff Garzik wrote:
> > updates my cirrus logic fbdev driver with a few cleanups, fix 0xA0000
> > bug (note to alan), module and PCI cleanups, ...
>
> Since clgen_of_init() is exactly the same as clgenfb_init(), and since clgenfb
> uses PCI resource management, can't we simply get rid of the OF specific stuff
> in clgenfb?
>
> Can someone please test this by disabling Offb (CONFIG_FB_OF=n) and seeing
> whether everything still works fine? Thanks!

I'd be glad to.  I tried doing this with pre6, and it failed; I attached the oops
to a previous message to fbdev, the hang seemed to be in init_vgachip.  (Also, the
board was mis-identified as having 32 MB RAM, it has just 4 MB.)  This is on a
StarMax 3000/160 (=pmac 4400) with a MacPicasso 540.  I don't see any changes to
init_vgachip in pre7-8; is there reason to believe this will work?

Unfortunately, I seem to have lost the original message with the patch, and it
doesn't seem to be in the archive at linux-fbdev.org or linuxppc.org (was it sent
to either list?).  Did the patch make it into pre7-8?  (The clgenfb version there
is 1.9.5; the vga16fb patch posted last Friday seems to have made it in.)  If not,
could someone please resend it to me?

Thanks,

-Adam P.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/