From: Dan Malek <dan@netx4.com>
To: Kim Jørgensen <KIJ@infocom.dk>
Cc: "'linuxppc-embedded@lists.linuxppc.org'"
<linuxppc-embedded@lists.linuxppc.org>
Subject: Re: Changes in the MPC8xx I2C driver
Date: Fri, 09 Jun 2000 13:13:00 -0400 [thread overview]
Message-ID: <3941259C.4E2F9B32@embeddededge.com> (raw)
In-Reply-To: 819E3E914E0AD11194DE00805F0D100B0138B86C@fbi.infocom.dk
Kim Jørgensen wrote:
> I have made some changes in the MPC8xx I2C driver, mainly adding write
> support and making the driver re-entrant.
Looks pretty good. I will add it to kernel sources.
> I don't use the minor number for the device address,
Did you investigate the Linux I2C implementation? I never did, but
perhaps it would be worthwhile to make this look like that at least
to an application.
> I have removed all of the microcode relocation code in the driver, as I
> couldn't make the driver work with this code and I had no need for applying
> the patch.
That is fine. I could never make it work either. I have had some
discussions with others about this, but no solution yet.
> I made some clumsy code for converting offset to internal address, maybe
> some one can tell me how to make this in a simpler way?
The challenge is some devices need this address, others don't. What
you have seems fine. After we use it for a while maybe we can find
something better.
Thanks.
-- Dan
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2000-06-09 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-06-09 10:19 Changes in the MPC8xx I2C driver Kim Jørgensen
2000-06-09 17:13 ` Dan Malek [this message]
2000-08-07 16:39 ` I2C,SPI and QMC Frank Przybylski
2000-08-07 17:42 ` Matthew Locke
2000-08-08 19:27 ` Dan Malek
2000-08-09 8:40 ` Frank Przybylski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3941259C.4E2F9B32@embeddededge.com \
--to=dan@netx4.com \
--cc=KIJ@infocom.dk \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).