From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C0148B6F76 for ; Sun, 7 Aug 2011 02:53:01 +1000 (EST) Subject: Re: [RFC 4/4] [powerpc] Implement a p1010rdb clock source. Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <4E3D4875.30707@pengutronix.de> Date: Sat, 6 Aug 2011 11:52:45 -0500 Message-Id: <39414D86-7822-4B92-B005-351890A2A167@kernel.crashing.org> References: <1312603504-30282-1-git-send-email-holt@sgi.com> <1312603504-30282-5-git-send-email-holt@sgi.com> <4E3D4875.30707@pengutronix.de> To: Marc Kleine-Budde Cc: Netdev , U Bhaskar-B22300 , socketcan-core@lists.berlios.de, Robin Holt , "linuxppc-dev@lists.ozlabs.org Development" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Aug 6, 2011, at 8:58 AM, Marc Kleine-Budde wrote: > On 08/06/2011 06:05 AM, Robin Holt wrote: >> flexcan driver needs the clk_get, clk_get_rate, etc functions >> to work. This patch provides the minimum functionality. >=20 > This patch has to go via the powerpc git tree. Added > linuxppc-dev@lists.ozlabs.org on CC. >=20 >> Signed-off-by: Robin Holt >> To: Marc Kleine-Budde >> To: Wolfgang Grandegger >> To: U Bhaskar-B22300 >> Cc: socketcan-core@lists.berlios.de >> Cc: netdev@vger.kernel.org >> --- >> arch/powerpc/platforms/85xx/p1010rdb.c | 78 = ++++++++++++++++++++++++++++++++ >> 1 files changed, 78 insertions(+), 0 deletions(-) NAK. This doesn't look right at all. We should be doing something based on = the device tree node that isn't board specific. I believe Bhaskar has a version of flexcan support that he's been = working on cleanup up for upstream. - k=