linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
	linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH] powerpc/mm: Remove DEBUG_VM_PGTABLE support on ppc64
Date: Tue, 1 Sep 2020 13:42:36 +0530	[thread overview]
Message-ID: <39467f79-d213-772d-9ed1-93afedc2fc7a@linux.ibm.com> (raw)
In-Reply-To: <4519baaa-cb95-6ebb-200f-4520badb56f6@csgroup.eu>

On 9/1/20 1:40 PM, Christophe Leroy wrote:
> 
> 
> Le 01/09/2020 à 10:02, Aneesh Kumar K.V a écrit :
>> The test is broken w.r.t page table update rules and results in kernel
>> crash as below. Disable the support untill we get the tests updated.
>>
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> 
> Any Fixes: tag ?
> 
>> ---
>>   arch/powerpc/Kconfig | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index 65bed1fdeaad..787e829b6f25 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -116,7 +116,6 @@ config PPC
>>       #
>>       select ARCH_32BIT_OFF_T if PPC32
>>       select ARCH_HAS_DEBUG_VIRTUAL
>> -    select ARCH_HAS_DEBUG_VM_PGTABLE
> 
> 
> You say you remove support for ppc64 but you are removing it for both 
> PPC64 and PPC32. Should you replace the line by:

Does it work on PPC32 with DEBUG_VM enabled? I was expecting it will be 
broken there too.

> 
>      select ARCH_HAS_DEBUG_VM_PGTABLE if PPC32
> 
>>       select ARCH_HAS_DEVMEM_IS_ALLOWED
>>       select ARCH_HAS_ELF_RANDOMIZE
>>       select ARCH_HAS_FORTIFY_SOURCE
>>
> 
> What about Documentation/features/debug/debug-vm-pgtable/arch-support.txt ?
> 

I am hoping we can enable the config once we resolve the test issues. 
may be in next merge window.

-aneesh




  reply	other threads:[~2020-09-01  8:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01  8:02 [PATCH] powerpc/mm: Remove DEBUG_VM_PGTABLE support on ppc64 Aneesh Kumar K.V
2020-09-01  8:10 ` Christophe Leroy
2020-09-01  8:12   ` Aneesh Kumar K.V [this message]
2020-09-01  8:15     ` Christophe Leroy
2020-09-01  9:10       ` Christophe Leroy
2020-09-01  9:13         ` Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39467f79-d213-772d-9ed1-93afedc2fc7a@linux.ibm.com \
    --to=aneesh.kumar@linux.ibm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).