CLLF860T FEC problem in linux-2.4.0-test4-pre6

CLLF860T FEC problem in linux-2.4.0-test4-pre6

[Graham Stoney]

Hi dudes,

I've just had a shot at running the latest 2.2.4-test4-pre6 snapshot on a
CLLF860T board, and I'm finding that opening the FEC driver fails, because
the PHY hasn't been recognised.  Firstly though, I had to apply this patch
to get the FEC initialised:

diff -ur linux-2.4.0-test4-pre6/drivers/net/setup.c linux-2.4.0-test4-pre6.cllf/drivers/net/setup.c
--- linux-2.4.0-test4-pre6/drivers/net/setup.c	Wed May 24 01:21:51 2000
+++ linux-2.4.0-test4-pre6.cllf/drivers/net/setup.c	Thu Jul 13 18:03:42 2000
@@ -22,6 +22,7 @@
 extern int awc4500_365_probe(void);
 extern int arcnet_init(void);
 extern int scc_enet_init(void);
+extern int fec_enet_init(void);
 extern int dlci_setup(void);
 extern int lapbeth_init(void);
 extern int sdla_setup(void);
@@ -74,6 +75,9 @@
 #endif
 #if defined(CONFIG_SCC_ENET)
         {scc_enet_init, 0},
+#endif
+#if defined(CONFIG_FEC_ENET)
+        {fec_enet_init, 0},
 #endif
 #if defined(CONFIG_COMX)
 	{comx_init, 0},


I have CONFIG_FEC_QS6612 enabled in fec.c, but it appears that I'm never
getting an MII interrupt, because fec_enet_interrupt is never called.
Hence, neither mii_discover_phy function gets called, and fec_enet_open later
fails with -ENODEV.

Has anyone got any clues on this before I dive into it tomorrow?

Thanks,
Graham
--
Graham Stoney
Principal Hardware/Software Engineer
Canon Information Systems Research Australia
Ph: +61 2 9805 2909  Fax: +61 2 9805 2929

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: CLLF860T FEC problem in linux-2.4.0-test4-pre6

[Dan Malek]

Graham Stoney wrote:

> Has anyone got any clues on this before I dive into it tomorrow?

A while back I posted a message stating I made lots of changes to this
driver based upon patches people have sent (including some of yours).
I also stated this is quite broken and I have not yet completed all
of the changes.  I am surprised it works at all.

I am now working on both the 8260 FCC (I have patches but will check
them in today), and the 8xx FEC as they are somewhat similar.


	-- Dan

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: CLLF860T FEC problem in linux-2.4.0-test4-pre6

[Graham Stoney]

Hi Dan,

Dan Malek writes:
> A while back I posted a message stating I made lots of changes to this
> driver based upon patches people have sent (including some of yours).
> I also stated this is quite broken and I have not yet completed all
> of the changes.  I am surprised it works at all.

Thanks for the clarification.  I don't have BitKeeper access because of the
firewall I'm behind, so I'm relying on the public snapshots to track what's
going on.  Things move so quick it's hard to keep up, and I haven't been
following 2.4 that closely up till now.

> I am now working on both the 8260 FCC (I have patches but will check
> them in today), and the 8xx FEC as they are somewhat similar.

OK, that sounds great.  While you're in there, any chance of getting this
little change committed to improve board-independence?:

diff -ur linux-2.4.0-test4-pre6/arch/ppc/8xx_io/fec.c linux-2.4.0-test4-pre6.cllf/arch/ppc/8xx_io/fec.c
--- linux-2.4.0-test4-pre6/arch/ppc/8xx_io/fec.c	Tue Jun 20 06:25:06 2000
+++ linux-2.4.0-test4-pre6.cllf/arch/ppc/8xx_io/fec.c	Fri Jul 14 12:42:23 2000
@@ -1572,8 +1572,8 @@
 	*/
 	*((uint *) RPX_CSR_ADDR) &= ~BCSR2_FETHLEDMODE;
 #endif
-#ifdef CONFIG_FADS
-	if (request_8xxirq(SIU_IRQ2, mii_link_interrupt, 0, "mii", dev) != 0)
+#ifdef PHY_INTERRUPT
+	if (request_8xxirq(PHY_INTERRUPT, mii_link_interrupt, 0, "mii", dev) != 0)
 		panic("Could not allocate MII IRQ!");
 #endif

diff -ur linux-2.4.0-test4-pre6/include/asm-ppc/fads.h linux-2.4.0-test4-pre6.cllf/include/asm-ppc/fads.h
--- linux-2.4.0-test4-pre6/include/asm-ppc/fads.h	Sun Nov 28 10:42:33 1999
+++ linux-2.4.0-test4-pre6.cllf/include/asm-ppc/fads.h	Thu Jul 13 18:59:38 2000
@@ -36,4 +36,6 @@
 #define PCMCIA_MEM_ADDR		((uint)0x04000000)
 #define PCMCIA_MEM_SIZE		((uint)(64 * 1024))

+#define PHY_INTERRUPT	SIU_IRQ2
+
 #endif

Thanks,
Graham
--
Graham Stoney
Principal Hardware/Software Engineer
Canon Information Systems Research Australia
Ph: +61 2 9805 2909  Fax: +61 2 9805 2929

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/