From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from VA3EHSOBE008.bigfish.com (va3ehsobe006.messaging.microsoft.com [216.32.180.16]) by ozlabs.org (Postfix) with ESMTP id 08BBBB70D1 for ; Sun, 19 Sep 2010 04:36:51 +1000 (EST) Subject: Re: [PATCH 1/2] powerpc: export ppc_tb_freq so that modules can reference it MIME-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset="us-ascii" From: Kumar Gala In-Reply-To: Date: Sat, 18 Sep 2010 13:36:43 -0500 Message-ID: <3AE9EB1F-2F5A-4A56-9171-BBAB8651C76C@freescale.com> References: <1284764008-19469-1-git-send-email-timur@freescale.com> <1284779678.30449.108.camel@pasglop> <70810686-1EB6-4AD9-A89B-C2A8BA6AC30D@freescale.com> To: Josh Boyer Cc: linuxppc-dev@ozlabs.org, Tabi Timur-B04825 , linux-watchdog@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sep 18, 2010, at 11:56 AM, Josh Boyer wrote: > On Sat, Sep 18, 2010 at 11:34 AM, Kumar Gala = wrote: >>=20 >> On Sep 18, 2010, at 9:36 AM, Tabi Timur-B04825 wrote: >>=20 >>> On Sep 17, 2010, at 10:14 PM, "Benjamin Herrenschmidt" = wrote: >>>=20 >>>> On Fri, 2010-09-17 at 20:20 -0500, Timur Tabi wrote: >>>>> I don't see any reason to limit it to GPL drivers. Not only that, = but >>>>> then we'll have this: >>>>=20 >>>> I do >>>=20 >>> Can you elaborate on that, or are you just going to pull rank on me? >>>=20 >>>>=20 >>>>> EXPORT_SYMBOL(ppc_proc_freq); >>>>> EXPORT_SYMBOL_GPL(ppc_tb_freq); >>>>>=20 >>>>> That just looks dumb. >>>>=20 >>>> Right, so send a patch to fix the first one too :-) >>=20 >> I don't think either of these should be EXPORT_SYMBOL_GPL. Why = shouldn't a binary module be allowed to know these frequencies? My view = is why preclude anyone from using this how they want. If they want to = live in the gray area so be it. Who am I to say they shouldn't have = that choice. >>=20 >=20 > It is not, in my opinion, about what is technically possible and what > isn't. The kernel is licensed under the GPL. This is a Linux kernel > only symbol. One would be hard pressed to claim they have a driver > that wasn't written for Linux that happens to need that symbol. As a > member of the Linux kernel community, I find it important to encourage > the contribution of code back to the kernel, and this is one way to > help that. This isn't BSD. >=20 > Besides, a developer is free to export it however they wish in their > own kernel tree. They can deviate from mainline if they so choose. I'll buy this argument as a reason to make both EXPORT_SYMBOL_GPL. - k=