Re: another endianness issue...

["Guillaume Laurès" <guillaume.laures@noos.fr>]

Timothy A. Seufert wrote:

> Kill the struct definition, and replace it with a bunch of accessor
> macros that mask-and-shift.  When moving the register value to or
> from the hardware, use le32_to_cpu() and cpu_to_le32() as appropriate.

Okay, so as this are my first steps in kernel programming, let's take an
example :-)

Somewhere at the beginning of the driver we have something like this:

while (DAC960_LA_InitializationInProgressP(BaseAddress))
{blabla}

DAC960_LA_InitializationInProgressP() is defined as follows in the .h:

static inline
boolean DAC960_BA_InitializationInProgressP(void *ControllerBaseAddress)
{
  DAC960_BA_InboundDoorBellRegister_T InboundDoorBellRegister;
  InboundDoorBellRegister.All =
   readb(ControllerBaseAddress + DAC960_BA_InboundDoorBellRegisterOffset);
  return !InboundDoorBellRegister.Read.InitializationNotInProgress;
}

and, for the record, the DAC960_BA_InboundDoorBellRegister_T is
something like this:

typedef union DAC960_BA_InboundDoorBellRegister
{
  unsigned char All;
  struct {
   boolean HardwareMailboxNewCommand:1;                /* Bit 0 */
   boolean AcknowledgeHardwareMailboxStatus:1;         /* Bit 1 */
   boolean GenerateInterrupt:1;                        /* Bit 2 */
   boolean ControllerReset:1;                          /* Bit 3 */
   boolean MemoryMailboxNewCommand:1;                  /* Bit 4 */
   unsigned char :3;                                   /* Bits 5-7 */
  } Write;
  struct {
   boolean HardwareMailboxEmpty:1;                     /* Bit 0 */
   boolean InitializationNotInProgress:1;              /* Bit 1 */
   unsigned char :6;                                   /* Bits 2-7 */
  } Read;
}
DAC960_BA_InboundDoorBellRegister_T;



What would I do now is modify  DAC960_LA_InitializationInProgressP() as
follows:

static inline
boolean DAC960_BA_InitializationInProgressP(void *ControllerBaseAddress)
{
  unsigned long InboundDoorBellRegister =
   le32_to_cpu(ControllerBaseAddress +
DAC960_BA_InboundDoorBellRegisterOffset);
  return (boolean) !(InboundDoorBellRegister & 0x0002);
}

Is it correct ?
And where can I find the cpu_to_le32() and le32_to_cpu() declaration or
a guide on how to use them ?

Thanks


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/