From: Adrian Cox <adrian@humboldt.co.uk>
To: "Justin (Gus) Hurwitz" <ghurwitz@dyndns.com>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: I want to break softirq.c to fix broken hardware
Date: Thu, 09 Aug 2001 19:08:08 +0100 [thread overview]
Message-ID: <3B72D188.4080902@humboldt.co.uk> (raw)
In-Reply-To: Pine.LNX.4.33.0108091722020.11077-100000@localhost.localdomain
Justin (Gus) Hurwitz wrote:
> #else
> __asm__ __volatile__("\n\
> 1: lwzx %0,0,%3\n\
> add %0,%2,%0\n\
> stwx %0,0,%3"
> : "=&r" (t), "=m" (v->counter)
> : "r" (a), "r" (v), "m" (v->counter)
> : "cc");
> #endif /* CONFIG_NO_ATOMICS */
Last time this came up I pointed out that lwarx/stwcx are for locking
against interrupts as well as against other CPUs. You don't seem to have
anything in your atomic routine to prevent interrupts occurring between
the load and the store.
--
Adrian Cox http://www.humboldt.co.uk/
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2001-08-09 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-09 21:56 I want to break softirq.c to fix broken hardware Justin (Gus) Hurwitz
2001-08-09 18:08 ` Adrian Cox [this message]
2001-08-09 22:32 ` Justin (Gus) Hurwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B72D188.4080902@humboldt.co.uk \
--to=adrian@humboldt.co.uk \
--cc=ghurwitz@dyndns.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).