From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <galak@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTP id 80C60DDED5
	for <linuxppc-dev@ozlabs.org>; Thu, 10 Jan 2008 06:27:50 +1100 (EST)
Message-Id: <3B831CF0-E978-42E7-BA26-7598BC27A5F6@kernel.crashing.org>
From: Kumar Gala <galak@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
In-Reply-To: <20080109185349.GC4337@loki.buserror.net>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Mime-Version: 1.0 (Apple Message framework v915)
Subject: Re: [PATCH] [POWERPC] Fix handling of memreserve if the range lands
	in highmem
Date: Wed, 9 Jan 2008 13:27:28 -0600
References: <Pine.LNX.4.64.0801091127400.8069@blarg.am.freescale.net>
	<20080109185349.GC4337@loki.buserror.net>
Cc: linuxppc-dev@ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>


On Jan 9, 2008, at 12:53 PM, Scott Wood wrote:

> On Wed, Jan 09, 2008 at 11:28:30AM -0600, Kumar Gala wrote:
>> 	/* reserve the sections we're already using */
>> -	for (i = 0; i < lmb.reserved.cnt; i++)
>> -		reserve_bootmem(lmb.reserved.region[i].base,
>> -				lmb_size_bytes(&lmb.reserved, i));
>> +	for (i = 0; i < lmb.reserved.cnt; i++) {
>> +		unsigned long addr = lmb.reserved.region[i].base +
>> +				     lmb_size_bytes(&lmb.reserved, i) - 1;
>> +		if (addr < total_lowmem)
>> +			reserve_bootmem(lmb.reserved.region[i].base,
>> +					lmb_size_bytes(&lmb.reserved, i));
>> +	}
>
> It looks like if the reserved area straddles the highmem boundary,  
> it'll
> only reserve the highmem portion.

Yeah, I thought about that.  I'm wondering if we should warn about  
this.. its seems like a bad thing to do.

- k