linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Dan Malek <dan@mvista.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-embedded@lists.linuxppc.org, Paul Mackerras <paulus@samba.org>
Subject: Re: Some more 4xx exception fixes
Date: Wed, 12 Sep 2001 11:42:24 -0400	[thread overview]
Message-ID: <3B9F8260.DA1C7EA@mvista.com> (raw)
In-Reply-To: 20010912133344.S4823@zax


David Gibson wrote:

> The problem was that the DSI handler would not call do_page_fault()
> for zone protection faults which were writes

The real problem is the zone protection isn't set up properly
on the kernel space.  The normal logic of the DSI will work
correctly without testing specifically for a zone protection error
if the zone is properly configured.  I noticed this error the other
day while fixing the other MMU problems, but it wasn't detrimental
to simply making the kernel run, so I'm fixing it today.

> The wart is that the ISI handler passed SRR1 (i.e. saved MSR) to
> do_page_fault(), whereas the comment above do_page_fault() says that
> do_page_fault() should be passed 0 for instruction faults on 4xx.

I guess....this is left over from a common exception handler I
suppose.  The only bit position tested is ESR_DST, which for the
last few years has always been reserved and zero in the MSR.  This
is a larger problem on other processors, where we overload this
code into the fault handler with bits that do mean something......


	-- Dan

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2001-09-12 15:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-12  3:33 Some more 4xx exception fixes David Gibson
2001-09-12 15:42 ` Dan Malek [this message]
2001-09-13  7:51   ` David Gibson
2001-09-13 20:42     ` Dan Malek
2001-09-13 22:26       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B9F8260.DA1C7EA@mvista.com \
    --to=dan@mvista.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).