From: "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, imunsie@au1.ibm.com
Subject: Re: [PATCH] cxl: fix setting of _PAGE_USER bit when handling page faults
Date: Tue, 29 Mar 2016 17:08:10 -0500 [thread overview]
Message-ID: <3BCAACA7-3DB2-4F6B-BE5C-96925C2ED4F8@linux.vnet.ibm.com> (raw)
In-Reply-To: <1458273681-18588-1-git-send-email-andrew.donnellan@au1.ibm.com>
> On Mar 17, 2016, at 11:01 PM, Andrew Donnellan =
<andrew.donnellan@au1.ibm.com> wrote:
>=20
> When handling page faults, cxl_handle_page_fault() checks whether the =
page
> should be accessible by userspace and have its _PAGE_USER access bit =
set.
> _PAGE_USER should be set if the context's kernel flag isn't set, or if =
the
> page falls outside of kernel memory.
>=20
> However, the check currently uses the wrong operator, causing it to =
always
> evalute to true. As such, we always set the _PAGE_USER bit, even when =
it
> should be restricted to the kernel.
>=20
> Fix the check so that the _PAGE_USER bit is set only as intended.
>=20
> Fixes: f204e0b8cedd ("cxl: Driver code for powernv PCIe based cards =
for
> userspace access")
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Per Ian's suggestion, I went ahead and tried this with cxlflash.
Tested-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
prev parent reply other threads:[~2016-03-29 22:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 4:01 [PATCH] cxl: fix setting of _PAGE_USER bit when handling page faults Andrew Donnellan
2016-03-18 6:30 ` Ian Munsie
2016-03-21 4:38 ` Andrew Donnellan
2016-03-25 10:01 ` Michael Ellerman
2016-03-25 17:15 ` Ian Munsie
2016-03-28 13:42 ` Aneesh Kumar K.V
2016-03-28 18:00 ` Aneesh Kumar K.V
2016-04-11 4:10 ` Andrew Donnellan
2016-04-11 4:27 ` Michael Ellerman
2016-04-11 4:31 ` Aneesh Kumar K.V
2016-04-11 11:14 ` Michael Ellerman
2016-04-11 13:42 ` Aneesh Kumar K.V
2016-04-12 11:42 ` Michael Ellerman
2016-03-29 22:08 ` Matthew R. Ochs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BCAACA7-3DB2-4F6B-BE5C-96925C2ED4F8@linux.vnet.ibm.com \
--to=mrochs@linux.vnet.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).