From: "David Müller (ELSOFT AG)" <d.mueller@elsoft.ch>
To: Tom Rini <trini@kernel.crashing.org>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: [PATCH] Various patches against linuxppc_dev-2.4.14-pre7
Date: Sat, 03 Nov 2001 09:19:51 +0100 [thread overview]
Message-ID: <3BE3A8A7.3070607@elsoft.ch> (raw)
In-Reply-To: 20011102092032.F26147@cpe-24-221-152-185.az.sprintbbd.net
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
Tom Rini wrote:
> On Fri, Nov 02, 2001 at 04:49:57PM +0100, David M?ller (ELSOFT AG) wrote:
>
>
>> - include/asm-ppc/ibm4xx.h
>> missing include file (I'm not sure if this is the correct fix)
>>
>> - drivers/net/ppc405_enet.h
>> missing include file (ditto)
>>
>
> What's broken right now? <asm/ibm405gp.h> gets included by CONFIG_FOO,
> if FOO is a 405GP board.
Sorry, my fault. I was a little bit too fast. ;-)
>
>
>
>> - arch/ppc/kernel/ppc4xx_setup.c
>> added call to board_setup_irq() in ppc4xx_init_IRQ()
>> added call to board_setup_rtc_access() in platform_init()
>>
>> - arch/ppc/kernel/walnut.c
>> - arch/ppc/kernel/redwood.c
>> - arch/ppc/kernel/cpci405.c
>> - arch/ppc/kernel/ep405.c
>> added necessary board_setup_irq() and
>> board_setup_rtc_access() functions
>>
>
> Shouldn't board_setup_rtc_access() do all of the RTC stuff, not just
> changing the nvram bits? If your board needs a different way to get
> nvram access, we should rename board_setup_rtc_access() to
> board_setup_nvram_access()
>
>
See attached patch
Dave
[-- Attachment #2: nvram_access.patch.bz2 --]
[-- Type: application/octet-stream, Size: 1046 bytes --]
next prev parent reply other threads:[~2001-11-03 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-02 15:49 [PATCH] Various patches against linuxppc_dev-2.4.14-pre7 David Müller (ELSOFT AG)
2001-11-02 16:20 ` Tom Rini
2001-11-03 8:19 ` David Müller (ELSOFT AG) [this message]
2001-11-05 17:05 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BE3A8A7.3070607@elsoft.ch \
--to=d.mueller@elsoft.ch \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).