From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6598FDE323 for ; Fri, 27 Jun 2008 01:02:18 +1000 (EST) Message-Id: <3BF4F03A-FD90-47BC-9F53-659848BE832E@kernel.crashing.org> From: Kumar Gala To: Liu Dave In-Reply-To: <58A20A281BAF1047B4EAE68DE5C0BDC201011622@zch01exm21.fsl.freescale.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Mime-Version: 1.0 (Apple Message framework v924) Subject: Re: [PATCH 1/3] mpc83xx: Power Management support Date: Thu, 26 Jun 2008 09:54:59 -0500 References: <20080625215051.GA11784@loki.buserror.net> <58A20A281BAF1047B4EAE68DE5C0BDC201011622@zch01exm21.fsl.freescale.net> Cc: Wood Scott , "linuxppc-dev@ozlabs.org list" , Benjamin Herrenschmidt List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Jun 26, 2008, at 9:39 AM, Liu Dave wrote: >>> Basic PM support for 83xx. Standby is implemented as sleep. >>> Suspend-to-RAM is implemented as "deep sleep" (with the processor >>> turned off) on 831x. PCI agent power management is supported. >>> >>> Device power management of SOC peripherals is not yet supported. >> >> (Not comments on this patch, but related) >> >> Do you know if anyone is looking at making sure DOZE/NAP work on >> 83xx? We clearly don't flush the L1 cache today in the 6xx code. > > I did the test on 837x, the NAP did *not* work, due to the cache > coherence issue. > You are right, currently no flush L1 in the 6xx code, maybe it > depend on > the > platform hardware capability. Ben told me the pmac HW/chipsets did something here to ensure that the core never actually went into NAP (or something like that) so they didn't have to flush the caches. - k