From: Dan Malek <dan@embeddededge.com>
To: Adrian Cox <adrian@humboldt.co.uk>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: [PATCH] Allow small areas in io_block_mapping
Date: Fri, 16 Nov 2001 11:57:13 -0500 [thread overview]
Message-ID: <3BF54569.3060000@embeddededge.com> (raw)
In-Reply-To: 3BF54157.6070605@humboldt.co.uk
Adrian Cox wrote:
> I hadn't realised that ioremap could be used before vmalloc was working,
> but on examining the code, it looks like it can. So I may just change my
> code to use ioremap.
Yeah, but just remember it does 1:1 virt->phys mapping. I have a couple
of 4xx processors with hard-wired low physical addresses, and I have to
force them to map to a "friendly" virtual address :-). That's the
only reason I like io_block_mapping(), but I don't have BATs to deal with.
> In defense of the patch....
You are correct. The comments in the code are kind of funny.....ensure
you call it with the right parameters, but then it checks some anyway.
> That's pretty well what I need here.
Let's do it. I think io_block_mapping() was conceptually copied from
other architectures for consistency, but I don't think it's doing the
right thing for us in all cases.
Thanks.
-- Dan
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2001-11-16 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-16 15:21 [PATCH] Allow small areas in io_block_mapping Adrian Cox
2001-11-16 16:14 ` Dan Malek
2001-11-16 16:39 ` Adrian Cox
2001-11-16 16:57 ` Dan Malek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BF54569.3060000@embeddededge.com \
--to=dan@embeddededge.com \
--cc=adrian@humboldt.co.uk \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).