* [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7
@ 2002-01-30 13:48 David Müller (ELSOFT AG)
2002-01-30 18:52 ` Armin Kuster
0 siblings, 1 reply; 6+ messages in thread
From: David Müller (ELSOFT AG) @ 2002-01-30 13:48 UTC (permalink / raw)
To: linuxppc-embedded
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
Hello
The attached patch fixes the following issues:
- arch/ppc/kernel/ppc4xx_pic.c
fixed constant in ppc405_pic_get_irq()
(should be NR_AIC_IRQS as in ppc403_pic_get_irq())
- arch/ppc/kernel/ppc_ksyms.c
added "consistent_sync_page"
- drivers/net/ppc405_enet.c
fixed old style register definitions in debug code
Dave
[-- Attachment #2: linuxppc.patch.bz2 --]
[-- Type: application/octet-stream, Size: 1080 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7
2002-01-30 13:48 [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7 David Müller (ELSOFT AG)
@ 2002-01-30 18:52 ` Armin Kuster
2002-01-31 8:29 ` David Müller (ELSOFT AG)
0 siblings, 1 reply; 6+ messages in thread
From: Armin Kuster @ 2002-01-30 18:52 UTC (permalink / raw)
To: David Müller; +Cc: linuxppc-embedded
"David Müller (ELSOFT AG)" wrote:
>
> Hello
>
> The attached patch fixes the following issues:
>
> - arch/ppc/kernel/ppc4xx_pic.c
> fixed constant in ppc405_pic_get_irq()
> (should be NR_AIC_IRQS as in ppc403_pic_get_irq())
David,
include/asm-ppc/irq.h
NR_IRQS = (NR_AIC_IRQS + NR_BOARD_IRQS) and was defined to allow
cascading UIC's.
NR_BOARD_IRQS is defined in some of the board files and its default is
in include/asm-ppc/ibm4xx.h
So i don't see the need to patch that file but the others look fine.
-- armin
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7
2002-01-30 18:52 ` Armin Kuster
@ 2002-01-31 8:29 ` David Müller (ELSOFT AG)
2002-01-31 18:15 ` Armin Kuster
0 siblings, 1 reply; 6+ messages in thread
From: David Müller (ELSOFT AG) @ 2002-01-31 8:29 UTC (permalink / raw)
To: Armin Kuster; +Cc: linuxppc-embedded
Hi
Armin Kuster wrote:
> "David Müller (ELSOFT AG)" wrote:
>
>>Hello
>>
>>The attached patch fixes the following issues:
>>
>> - arch/ppc/kernel/ppc4xx_pic.c
>> fixed constant in ppc405_pic_get_irq()
>> (should be NR_AIC_IRQS as in ppc403_pic_get_irq())
>>
>
> David,
>
> include/asm-ppc/irq.h
> NR_IRQS = (NR_AIC_IRQS + NR_BOARD_IRQS) and was defined to allow
> cascading UIC's.
> NR_BOARD_IRQS is defined in some of the board files and its default is
> in include/asm-ppc/ibm4xx.h
>
> So i don't see the need to patch that file but the others look fine.
>
>
Exactly, NR_IRQS is the the total number of irqs possible in the system
as this number of irqs is reserved in the irq_desc table.
For example, we have a system with a PPC405GP and an additional PC like 8259 PIC
pair, we have NR_AIC_IRQS (32) + NR_BOARD_IRQS (16) = NR_IRQS (48).
In ppc405_pic_get_irq() the following code is executed:
irq = 32 - ffs(bits);
if (irq == NR_IRQS)
irq = -1;
return(irq);
with NR_IRQS equal 48 the condition is never true !
This results in an endless while-loop in do_IRQ() in arch/ppc/kernel/irq.c
Either this or my understanding how things are working is totally wrong. ;-)
Additionally, i don't see me why ppc403_pic_get_irq() is using NC_AIC_IRQS while
ppc405_pic_get_irq() is using NR_IRQS. Shouldn't they be "symmetric".
Dave
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7
2002-01-31 8:29 ` David Müller (ELSOFT AG)
@ 2002-01-31 18:15 ` Armin Kuster
2002-01-31 18:26 ` Mark Pilon
0 siblings, 1 reply; 6+ messages in thread
From: Armin Kuster @ 2002-01-31 18:15 UTC (permalink / raw)
To: David Müller; +Cc: linuxppc-embedded
"David Müller (ELSOFT AG)" wrote:
>
> Hi
>
> Armin Kuster wrote:
>
> > "David Müller (ELSOFT AG)" wrote:
> >
> >>Hello
> >>
> >>The attached patch fixes the following issues:
> >>
> >> - arch/ppc/kernel/ppc4xx_pic.c
> >> fixed constant in ppc405_pic_get_irq()
> >> (should be NR_AIC_IRQS as in ppc403_pic_get_irq())
> >>
> >
> > David,
> >
> > include/asm-ppc/irq.h
> > NR_IRQS = (NR_AIC_IRQS + NR_BOARD_IRQS) and was defined to allow
> > cascading UIC's.
> > NR_BOARD_IRQS is defined in some of the board files and its default is
> > in include/asm-ppc/ibm4xx.h
> >
> > So i don't see the need to patch that file but the others look fine.
> >
> >
>
> Exactly, NR_IRQS is the the total number of irqs possible in the system
> as this number of irqs is reserved in the irq_desc table.
>
> For example, we have a system with a PPC405GP and an additional PC like 8259 PIC
> pair, we have NR_AIC_IRQS (32) + NR_BOARD_IRQS (16) = NR_IRQS (48).
>
> In ppc405_pic_get_irq() the following code is executed:
>
> irq = 32 - ffs(bits);
>
> if (irq == NR_IRQS)
> irq = -1;
>
> return(irq);
>
> with NR_IRQS equal 48 the condition is never true !
>
> This results in an endless while-loop in do_IRQ() in arch/ppc/kernel/irq.c
>
> Either this or my understanding how things are working is totally wrong. ;-)
> Additionally, i don't see me why ppc403_pic_get_irq() is using NC_AIC_IRQS while
> ppc405_pic_get_irq() is using NR_IRQS. Shouldn't they be "symmetric".
>
> Dave
David,
your right.
-- armin
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7
2002-01-31 18:15 ` Armin Kuster
@ 2002-01-31 18:26 ` Mark Pilon
2002-01-31 18:42 ` Dan Malek
0 siblings, 1 reply; 6+ messages in thread
From: Mark Pilon @ 2002-01-31 18:26 UTC (permalink / raw)
To: Armin Kuster; +Cc: David Müller, linuxppc-embedded
> >
> > In ppc405_pic_get_irq() the following code is executed:
> >
> > irq = 32 - ffs(bits);
> >
> > if (irq == NR_IRQS)
> > irq = -1;
> >
> > return(irq);
> >
> > with NR_IRQS equal 48 the condition is never true !
> >
You might check the actual code generated for ffs() and verify
it works -- I ended up recoding this routine because ffs() wasn't
working correctly ... [ I forget the particulars, but the code
generated and behavior were not correct ];
Mark
--
Mark Pilon
Minolta-QMS
P.O. Box 37
Fallon, MT. 59326-0037
1-406-486-5539 (primary voice line)
1-406-853-0433 (cell)
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7
2002-01-31 18:26 ` Mark Pilon
@ 2002-01-31 18:42 ` Dan Malek
0 siblings, 0 replies; 6+ messages in thread
From: Dan Malek @ 2002-01-31 18:42 UTC (permalink / raw)
To: Mark Pilon
Cc: Armin Kuster, David Müller ( ELSOFT AG), linuxppc-embedded
Mark Pilon wrote:
> You might check the actual code generated for ffs() and verify
> it works -- I ended up recoding this routine because ffs() wasn't
> working correctly ... [ I forget the particulars, but the code
> generated and behavior were not correct ];
It would be nice if you posted the particulars. This function is
used in a variety of places, and it appears to work just fine.
Thanks.
-- Dan
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-01-31 18:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-01-30 13:48 [PATCH] 3 patches against linuxppc_dev-2.4.18-pre7 David Müller (ELSOFT AG)
2002-01-30 18:52 ` Armin Kuster
2002-01-31 8:29 ` David Müller (ELSOFT AG)
2002-01-31 18:15 ` Armin Kuster
2002-01-31 18:26 ` Mark Pilon
2002-01-31 18:42 ` Dan Malek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).