From: Armin <akuster@pacbell.net>
To: "David Müller (ELSOFT AG)" <d.mueller@elsoft.ch>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: [PATCH] Several patches against linuxppc_devel-2.4.18-rc1
Date: Sun, 17 Feb 2002 15:27:57 +0000 [thread overview]
Message-ID: <3C6FCBFD.80504@pacbell.net> (raw)
In-Reply-To: 3C6E5603.5010801@elsoft.ch
David Müller (ELSOFT AG) wrote:
> Hello
>
> The attached patch fixes the following issues:
>
> - arch/ppc/kernel/Makefile
> ppc4xx_pm.o missing in export-objs list
>
> - arch/ppc/kernel/ppc4xx_pm.c
> missing include file + missing #ifdef #endif
>
ok.
> - arch/ppc/kernel/ppc4xx_pic.c
> fixed constant in ppc405_pic_get_irq()
> (NR_IRQS is not necessarily the total number of UIC irqs)a
hmmmmm... we should get ride of "NR_BOARD_IRQS" instead?
>
> - arch/ppc/platforms/ibm_ocp.h
> wrong header file included + some little name fixes
header file fix all ready in. I will get the name change next patch in.
>
>
> Regarding the newly introduce support for cascaded UICs:
>
> Isn't the CONFIG_CASCADING_UIC option redundant?
> If (CONFIG_CASCADING_UIC == (NR_UICS > 1)) is true, CONFIG_CASCADING_UIC
> could be replace by (NR_UICS > 1).
>
Good point:)
> Dave
Armin
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-02-17 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-16 12:52 [PATCH] Several patches against linuxppc_devel-2.4.18-rc1 David Müller (ELSOFT AG)
2002-02-17 15:27 ` Armin [this message]
2002-02-18 12:35 ` David Müller (ELSOFT AG)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C6FCBFD.80504@pacbell.net \
--to=akuster@pacbell.net \
--cc=d.mueller@elsoft.ch \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).