linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Armin <akuster@pacbell.net>
To: andrew may <acmay@acmay.homeip.net>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: [PATCH] another for ibm_ocp_enet
Date: Fri, 15 Mar 2002 11:48:16 +0000	[thread overview]
Message-ID: <3C91DF80.4040904@pacbell.net> (raw)
In-Reply-To: 20020314222859.A24861@ecam.san.rr.com


andrew may wrote:
> This patch includes the last patch that I sent before the
> directory move, plus some more stuff.
>
> 1. Fix merge error with MAX_NUM_PHYS in find phy loop.
> (the for loop condition should match the if check)
>
> 2. Fix bad Partner Link check for the added Phy.
>
> 3. added mal.sh to generate a new ibm_ocp_mal.c
> 	mal.sh  DCRN_MAL_BASE >ibm_ocp_mal.c
> or	mal.sh  DCRN_MAL_BASE DCRN_MAL1_BASE >ibm_ocp_mal.c
> will work. It seems that the second on generates a smaller
> object file even though the code is bigger for the 405GP.
> I would think it is because MAL1 is 0.
> This condenses all the get/set mal calls into one for get
> and one for set. I also changed mal_num to mal, just to help
> me find/change things.

The script idea is cool.

The mal_num is more descriptive to me so give me a better argument

>
> I think this is a better approach than what was in the _mal.c,
> but I didn't change the makefile to generate the code on the
> fly yet.
>
> 4. Added skb_res as a module param and config.in option.
>
> 5. Created rx_clean/fill functions to remove duplicate code
> in open and the 2 rx interrupts.
>
> 6. Handle dev_alloc failures better by retrying to alloc before
> the rxde interrupt.
>

armin


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

           reply	other threads:[~2002-03-15 11:48 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20020314222859.A24861@ecam.san.rr.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C91DF80.4040904@pacbell.net \
    --to=akuster@pacbell.net \
    --cc=acmay@acmay.homeip.net \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).