From: Armin <akuster@pacbell.net>
To: andrew may <acmay@acmay.homeip.net>
Cc: linuxppc-embedded <linuxppc-embedded@lists.linuxppc.org>
Subject: Re: [PATCH] IBM ocp I2C
Date: Sat, 27 Apr 2002 21:09:18 -0700 [thread overview]
Message-ID: <3CCB75EE.1080208@pacbell.net> (raw)
In-Reply-To: 20020426203505.A1819@ecam.san.rr.com
andrew may wrote:
> On Fri, Apr 26, 2002 at 01:48:48PM -0700, Armin wrote:
>
>>>In this patch I dump getown and getclock because they aren't
>>>used and I am sure there is a better way to do things.
>>>
>>this does not work on Walnut since "procfreq" is not part of openbios
>>and the PLLMR does not exsist on the stb03 or 03 so this changes wont
>>go in.
>>
>
> I don't have a stb03 or even know what chip it uses, so I have
> no idea what to do about it. We should have some generic 4xx
> functions to get the CPU/PLB/OPB clocks so we can calculate what
> the I2C div should be. We could always try trusing what the BIOS
> sets the divider to as well.
>
>
>
Andrew,
I agree, the issue I have is that the clock solution was too arch/bios
specific and should reside somewhere outside the driver in the form of a
fuction or variable (as you suggest) that can take into accout the
differences in arch and possibly bios.
Thanks
armin
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-04-28 4:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-24 3:01 [PATCH] IBM ocp I2C andrew may
2002-04-24 3:01 ` andrew may
2002-04-24 4:36 ` Armin
2002-04-24 15:18 ` andrew may
2002-04-24 18:26 ` andrew may
2002-04-24 18:45 ` Armin
2002-05-01 17:05 ` Armin
2002-04-26 20:48 ` Armin
2002-04-27 3:35 ` andrew may
2002-04-28 4:09 ` Armin [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-04-29 21:40 [PATCH]IBM OCP I2C andrew may
[not found] ` <3CCDE113.5000700@pacbell.net>
2002-04-30 0:05 ` andrew may
2002-05-07 18:33 andrew may
2002-05-07 19:54 ` andrew may
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CCB75EE.1080208@pacbell.net \
--to=akuster@pacbell.net \
--cc=acmay@acmay.homeip.net \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).