linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Dan Malek <dan@embeddededge.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Tom Rini <trini@kernel.crashing.org>,
	Armin Kuster <akuster@mvista.com>,
	linuxppc-embedded@lists.linuxppc.org,
	Paul Mackerras <paulus@samba.org>
Subject: Re: Another OCP enet patch
Date: Thu, 30 May 2002 00:16:24 -0400	[thread overview]
Message-ID: <3CF5A798.3010500@embeddededge.com> (raw)
In-Reply-To: 20020530030933.GJ16537@zax


David Gibson wrote:

> I'm attempting to argue that changing the callers of consistent_sync()
> to use the PCI_DMA_* constants ....

I see.  I think that would be fine as long as we can compile and get
these constants defined without having to enable CONFIG_PCI.  It is
a little weird to include pci header files in drivers that don't use it :-)

> I do want to change the flags to consistent_sync() but only if we
> change it everywhere, including in all the PCI stuff: that requires
> convincing Linus, and probably won't happen at all in 2.4.

But, doesn't that involve adding code to test PCI flags and convert
them to consistent_sync() flags that you didn't want to do?

How about this, we just add another set of flags that are disjoint
from the PCI flags, and just test for both in consistent_sync()?

Thanks.


	-- Dan


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2002-05-30  4:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-27  4:03 Another OCP enet patch David Gibson
2002-05-27  6:14 ` Armin Kuster
2002-05-27 16:23 ` Tom Rini
2002-05-28  0:57   ` David Gibson
2002-05-28  1:25     ` Tom Rini
2002-05-28  6:36       ` David Gibson
2002-05-28 15:08         ` Tom Rini
2002-05-28  7:02       ` Armin
2002-05-28  6:50         ` David Gibson
2002-05-28 10:51           ` Dan Malek
2002-05-29  3:48             ` David Gibson
2002-05-29 14:51               ` Dan Malek
2002-05-28 10:39     ` Dan Malek
2002-05-29  4:16       ` David Gibson
2002-05-29 15:02         ` Dan Malek
2002-05-29 16:01           ` Armin Kuster
2002-05-30  3:10             ` David Gibson
2002-05-30  3:09           ` David Gibson
2002-05-30  4:16             ` Dan Malek [this message]
2002-05-30  4:30               ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CF5A798.3010500@embeddededge.com \
    --to=dan@embeddededge.com \
    --cc=akuster@mvista.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    --cc=paulus@samba.org \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).