From: Dan Malek <dan@embeddededge.com>
To: Eugene Surovegin <ebs@innocent.com>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: consistent_alloc from an interrupt context
Date: Thu, 13 Jun 2002 00:05:46 -0400 [thread overview]
Message-ID: <3D081A1A.70309@embeddededge.com> (raw)
In-Reply-To: 5.1.0.14.2.20020612200144.00ab2398@mail.zultys.com
Eugene Surovegin wrote:
> Current PPC implementation of consistent_alloc cannot be called from an
> interrupt context.
Hmmmm.....Why did I think this was corrected in the past? I see all of
the consistent_alloc users are doing the same thing. I know we discussed
this, and the solution was actually quite trivial. All we have to do is
pass a GFP_ATOMIC into the kmalloc() (called by get_vm_area()). IIRC,
we added a 'gfp' parameter to get_vm_area() (and changed all callers, which
was just a few), and then passed the 'gfp' into the kmalloc(). I know
many of us tried it and everything worked sweetly :-)
I thought the change was readily accepted by the generic code powers, I guess
no one actually checked it in :-) You could make the change locally and have
a good day :-) All you have to do is add the parameter to get_vm_area(),
find all of the places it is currently called and add 'GFP_KERNEL' as the
parameter. In consistent_alloc(), just pass the 'gfp' variable.
-- Dan
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-06-13 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-13 3:22 consistent_alloc from an interrupt context Eugene Surovegin
2002-06-13 4:05 ` Dan Malek [this message]
2002-06-13 4:24 ` Eugene Surovegin
2002-06-13 5:06 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D081A1A.70309@embeddededge.com \
--to=dan@embeddededge.com \
--cc=ebs@innocent.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).