From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <3D29B8CB.9020204@dslextreme.com> Date: Mon, 08 Jul 2002 09:07:39 -0700 From: Armin MIME-Version: 1.0 To: Tom Rini Cc: Paul Mackerras , linuxppc-dev@lists.linuxppc.org Subject: Re: [PATCH/RFC] Change how we pick which _kd_mksound to use. References: <20020701152727.GC20920@opus.bloom.county> <15655.39445.566490.16876@argo.ozlabs.ibm.com> Content-Type: text/plain; charset=us-ascii; format=flowed Sender: owner-linuxppc-dev@lists.linuxppc.org List-Id: Paul Mockeries wrote: >Tom Rind writes: > >>The following changes how we pick a _kd_mksound. The problem is that on >>some machines, such as IBM405, the default _kd_mksound breaks horribly >>due to the inb/outb's attempting to fiddle with timers which don't >>exist. This changes the test which selects either an empty _kd_mksound >>or the one in question from __powerpc__ to CONFIG_PPC64 (since from what I >>understand, __powerpc__ is defined on ppc64) || (CONFIG_PPC32 && >>CONFIG_6xx). The CONFIG_6xx test is because these boards are the ones >>which tend to have a SuperIO chip, or something else with the timers at >>0x61, 0xB6, etc. >> >>The other option would be to define an empty no_kd_mksound or so on >>4xx/8xx and then conditionally set kd_mksound to that, but I would >>prefer this since we're already doing some preprocessor checks anyhow. >> It looks to me as if the CONFIG_REDWOOD should be changed to CONFIG_4XX to start with and there are no guarantees that the timer will be at the same locations plus on a pci base 4xx , in*/out* can't br used on local bus i/o access. > >This is one of those "there's got to be a better way" places. The >CONFIG_PPC32 && CONFIG_6xx test doesn't really capture what we want >much better than the existing __powerpc__ test does. Testing >CONFIG_PPC32 && CONFIG_ISA might go closer. I would really rather >that _kd_mksound was provided in the platform-specific files on those >platforms where it applies, though. > >Paul. > For 4xx it should be defined at the board level in most cases :) armin ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/