[RFC/Patch] ppc4xx_pic

[RFC/Patch] ppc4xx_pic

[akuster]

Hello;

While farting around with some 4xx drivers,  I came accross a few that
changed the level and polarity of their irq before calling request_irq().
 So I am thinking of adopting how openpic defines and gets irq level and
polarity information and use it to define  external irqs in the board.c
files.

Basicaly I check to see if a table exists and if so, update the
interrupt controller during ppc4xx_pic_init with the proper values.
 Since the on-chip devices are all ready setup by the bootrom or at
least we have been assuming this is the case ,  I am not going to worry
about them.

Since I plan on updating the ppc4xx_pic , I have also added the ability
to properly report the level of the interrupt to irq_desc[] so that
proc/intrrupts will correct.

what do you think?

armin


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: [RFC/Patch] ppc4xx_pic

[Dan Malek]

akuster wrote:

> Basicaly I check to see if a table exists and if so, update the
> interrupt controller during ppc4xx_pic_init with the proper values.
> Since the on-chip devices are all ready setup by the bootrom or at
> least we have been assuming this is the case ,  I am not going to worry
> about them.

My only suggestion is to make the table always exist (removing the
"if it exists" option), and to represent all interrupts (like openpic
does).  It may make the rest of the supporting software easier to
write and will serve as a source of documentation for what the boot rom
may configure. :-)

Thanks.


	-- Dan


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/