Re: consistent_alloc() revisited

[Dan Malek <dan@embeddededge.com>]

David Gibson wrote:

> In addition, the following seem to me like desirable (to a greater or
> lesser extent) properties for consistent_alloc():
> 	a. one of the return values can be used as a single "handle"
> so that consistent_free() only needs one parameter.

We want the implementation API to be identical across all architectures.
Until there is a consistent way of handling devices that are on local
processor busses, platforms with these types of devices may call these
functions directly.    This is particularly true of some host USB controllers
on embedded systems that don't have PCI busses.

> 	b. works on both cache coherent and non cache coherent
> machines

The original purpose of the consistent_* functions was to provide support
for processors that aren't cache coherent.  The pci_* (and any other functions)
can call these if appropriate, but I still believe the decision should  be
made at a higher level.  Obviously, these consistent_* functions will
be implemented differently on non- or cache coherent processors, and across
different architectures.  The PCI functions (or others) should still do their
thing as they always have, and call these consistent_* functions when
appropriate.


> 	c. be able to use highmem pages

You think there will be non-coherent processors with this much memory? :-)


> -	if (in_interrupt())
> -		BUG();
> +	BUG_ON(in_interrupt());

We should be able to call these functions from interrupt, let's push
the remainder of the changes though get_free_pages() to make this happen.


Thanks.


	-- Dan


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/