From: akuster <akuster@dslextreme.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Armin Kuster <akuster@mvista.com>, linuxppc-embedded@lists.linuxppc.org
Subject: Re: request_irq() bug in ENET driver?
Date: Wed, 21 Aug 2002 23:02:06 -0700 [thread overview]
Message-ID: <3D647E5E.9060708@dslextreme.com> (raw)
In-Reply-To: 20020821045259.GG18818@zax
David Gibson wrote:
> This code comes from ppc405_enet_open():
>
> if (!(get_mal_dcrn(fep->mal, DCRN_MALTXCASR))) {
> request_irq(BL_MAC_WOL,ppc405_eth_wakeup,0,"OCP EMAC Wakeup",dev);
> request_irq(BL_MAL_SERR,ppc405_eth_serr,0,"OCP EMAC MAL SERR",dev);
> request_irq(BL_MAL_TXDE,ppc405_eth_txde,0,"OCP EMAC TX DE ",dev);
>
> request_irq(BL_MAL_RXDE,ppc405_eth_rxeob,0,"OCP EMAC RX DE",dev);
>
> request_irq(BL_MAL_TXEOB,ppc405_eth_txeob,0,"OCP EMAC TX EOB",dev);
> request_irq(BL_MAL_RXEOB,ppc405_eth_rxeob,0,"OCP EMAC RX EOB",dev);
> }
>
> ppc405_eth_rxeob is being registed twice, both for the MAL_RXEOB and
> for the MAL_RXDE interrupts, and ppc405_eth_rxde() is registered
> never. Is there a reason for this, or is it just a bug?
>
> --
> David Gibson | For every complex problem there is a
> david@gibson.dropbear.id.au | solution which is simple, neat and
> | wrong.
> http://www.ozlabs.org/people/dgibson
>
>
>
>
>
David,
Its a bug Eugene pointed out to me a while back, patch tomorrow for this
and other changes Eugene sent me.
Armin
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2002-08-22 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-21 4:52 request_irq() bug in ENET driver? David Gibson
2002-08-22 6:02 ` akuster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D647E5E.9060708@dslextreme.com \
--to=akuster@dslextreme.com \
--cc=akuster@mvista.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).