From: akuster <akuster@dslextreme.com>
To: Todd Poynor <tpoynor@mvista.com>
Cc: jim <jduey@ccc-dcs.com>, linuxppc-embedded@lists.linuxppc.org
Subject: Re: Question about ppc4xx_dma.h
Date: Wed, 21 Aug 2002 23:18:58 -0700 [thread overview]
Message-ID: <3D648252.4010807@dslextreme.com> (raw)
In-Reply-To: 3D641186.2020800@mvista.com
Todd Poynor wrote:
>
> Noticed that the order of clearing the old transfer mode bits and
> setting the p_dma_ch->mode bits is reversed in the new patch, not sure
> if this causes problems:
>
> + tmp_cntl |= (p_dma_ch->mode | DMA_CH_ENABLE);
> +
> + switch (dmanr) {
> + case 0:
> + control = mfdcr(DCRN_DMACR0);
> + control |= tmp_cntl;
> + control &= ~(DMA_TM_MASK | DMA_TD); /* clear all
> mode bits */
>
> This seems to set and then clear the p_dma_ch->mode bits in control
> prior to writing to the DMACR, a problem?
>
>
> --
> Todd
>
Todd,
yeap, looks like it.
armin
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-08-22 6:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-20 15:26 Question about ppc4xx_dma.h jim
2002-08-20 23:18 ` akuster
2002-08-21 19:39 ` akuster
2002-08-21 22:17 ` Todd Poynor
2002-08-22 6:18 ` akuster [this message]
2002-08-27 3:44 ` akuster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D648252.4010807@dslextreme.com \
--to=akuster@dslextreme.com \
--cc=jduey@ccc-dcs.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=tpoynor@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).