From: Dan Malek <dan@embeddededge.com>
To: "Hans dot Feldt at uab.ericsson.se" <"Hans dot Feldt at
uab.ericsson.se"@uab.ericsson.se>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: immap_8260.h: volatile missing in immr definition
Date: Fri, 06 Sep 2002 10:30:49 -0400 [thread overview]
Message-ID: <3D78BC19.7000506@embeddededge.com> (raw)
In-Reply-To: 200209061149.g86BnwH05287@wnaw252.uab.ericsson.se
Hans dot Feldt at uab.ericsson.se wrote:
> Change from: extern immap_t *immr:
> to: extern volatile immap_t *immr;
Rather than do this, I would prefer you use a function local variable
and load the global immr into it. You should also get into the habit
of using barrier operations between such I/O accesses that must be
properly ordered. The global volatile declaration isn't sufficient
to enforce ordered operations. You just got lucky this time.
Thanks.
-- Dan
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2002-09-06 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-06 11:49 immap_8260.h: volatile missing in immr definition Hans dot Feldt at uab.ericsson.se
2002-09-06 14:30 ` Dan Malek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D78BC19.7000506@embeddededge.com \
--to=dan@embeddededge.com \
--cc="Hans dot Feldt at uab.ericsson.se"@uab.ericsson.se \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).