From: Hans Feldt <Hans.Feldt@uab.ericsson.se>
To: Joakim Tjernlund <Joakim.Tjernlund@lumentis.se>
Cc: linuxppc-embedded@lists.linuxppc.org, scop@digitel.com.br,
thomas@corelatus.com
Subject: Re: [PATCH] arch/ppc/8xx_io/enet.c, version 2
Date: Wed, 13 Nov 2002 14:50:14 +0100 [thread overview]
Message-ID: <3DD25896.6020603@uab.ericsson.se> (raw)
In-Reply-To: 200210241423.g9OENV4d024137@blooper.utfors.se
On 10/24/02 04:23 PM, Joakim Tjernlund wrote:
> Hi
>
> This is the second version of my patch that removes the expensive memcpy of
> received
> ethernet frames in interrupt context.
Isn't it so that this patch works because you have snooping? Without
snooping the driver would fail because of cache line replacement which
could trash received data.
The buffer invalidate in this case is unneeded. But if you wanna
optimise you should invalidate the whole buffer before giving it to DMA
thus getting rid of the flush implied by memory coherence.
Tried this out in a driver for a processor without snooping, now and
then received packets got corrupted, cache line wise...
Just trying to understand how things really work, please correct me if I
am wrong.
Cheers,
Hans
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-11-13 13:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-24 14:23 [PATCH] arch/ppc/8xx_io/enet.c, version 2 Joakim Tjernlund
2002-10-24 14:59 ` Tom Rini
2002-10-24 15:46 ` Joakim Tjernlund
2002-11-01 11:01 ` Joakim Tjernlund
2003-01-28 11:54 ` [PATCH] arch/ppc/8xx_io/enet.c, version 3 Joakim Tjernlund
2003-02-03 10:21 ` Joakim Tjernlund
2003-02-03 12:28 ` Pantelis Antoniou
2002-10-28 15:17 ` [PATCH] arch/ppc/8xx_io/enet.c, version 2 Stephan Linke
2002-10-28 17:24 ` Joakim Tjernlund
2002-11-13 13:50 ` Hans Feldt [this message]
2002-11-13 16:35 ` Joakim Tjernlund
2002-11-13 19:30 ` Hans Feldt
2002-11-13 21:19 ` Joakim Tjernlund
2002-11-13 22:12 ` Dan Malek
2002-11-13 22:54 ` Joakim Tjernlund
2002-11-15 11:52 ` Hans Feldt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DD25896.6020603@uab.ericsson.se \
--to=hans.feldt@uab.ericsson.se \
--cc=Joakim.Tjernlund@lumentis.se \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=scop@digitel.com.br \
--cc=thomas@corelatus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).