From: Dan Malek <dan@embeddededge.com>
To: joakim.tjernlund@lumentis.se
Cc: Shen Rong <rshen@udtech.com.cn>, linuxppc-embedded@lists.linuxppc.org
Subject: Re: wrong definition in cpm_8260.h?
Date: Wed, 22 Jan 2003 17:20:16 -0500 [thread overview]
Message-ID: <3E2F1920.9070702@embeddededge.com> (raw)
In-Reply-To: IGEFJKJNHJDCBKALBJLLGEIOFJAA.joakim.tjernlund@lumentis.se
Joakim Tjernlund wrote:
> Yes, the CPM will set these flags, but will it also clear them if the
> buffer is not first/last in a frame? I think not.
It doesn't matter. The flags are always going to be set. Why bother
clearing them when you always set them?
> I know that the driver is designed to always set them so in practise it
> won't be problem. However this could change some day.
Well, when it changes we can change the code to set/clear the flags
according to the buffer management algorithm.
> yes I know, but I still think those flags should be included in the RX_STATS macro.
Why? Like I said in the previous message, they aren't part of any network
status. They are buffer control flags and need to properly indicate how the
buffers are managed, not cleared as part of network status.
-- Dan
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-01-22 22:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-22 11:03 wrong definition in cpm_8260.h? Shen Rong
2003-01-22 14:54 ` Joakim Tjernlund
2003-01-22 18:04 ` Dan Malek
2003-01-22 21:33 ` Joakim Tjernlund
2003-01-22 22:20 ` Dan Malek [this message]
2003-01-22 23:08 ` Joakim Tjernlund
2003-01-23 2:04 ` Shen Rong
2003-01-23 15:45 ` Dan Malek
2003-01-24 2:20 ` Shen Rong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E2F1920.9070702@embeddededge.com \
--to=dan@embeddededge.com \
--cc=joakim.tjernlund@lumentis.se \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=rshen@udtech.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).