From: Steven Scholz <steven.scholz@imc-berlin.de>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Linuxppc-Embedded <linuxppc-embedded@lists.linuxppc.org>
Subject: Re: was: FEC on MPC860T & race condition
Date: Fri, 07 Feb 2003 08:37:05 +0100 [thread overview]
Message-ID: <3E436221.8040903@imc-berlin.de> (raw)
In-Reply-To: 20030204193224.GB3522@ip68-0-152-218.tc.ph.cox.net
Tom Rini wrote:
>...
> Okay. Moving along the process, I have a comment:
>
>
>>@@ -2285,6 +2278,39 @@
>> fep->old_status = 0;
>> #endif /* CONFIG_USE_MDIO */
>>
>>+#ifdef CONFIG_USE_MDIO
>>+# ifndef PHY_INTERRUPT
>>+# error Want to use MII, but PHY_INTERRUPT not defined!
>>+# endif
>>+ /* before requesting the irq, we should wait until PHY is discovered
>>+ * to avoid race conditions
>>+ */
>>+ while (!fep->phy_id_done) {
>>+ udelay(5);
>>+ }
>
>
> I believe this is wrong, in that trying to udelay() here is a bad idea.
> I don't have the time right now, but I suspect google, or #kernelnewbies
> might be able to suggest a more appropriate way of waiting here.
>
> Or perhaps classes have fried my mind, and this is correct.
No. I bet you're right.
But can you make any suggestion on how to wait for some I/O to become ready?
Steven
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-02-07 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-30 17:05 was: FEC on MPC860T & race condition Steven Scholz
2003-01-30 20:22 ` Dan Malek
2003-01-31 9:16 ` Steven Scholz
2003-02-03 21:09 ` Tom Rini
2003-02-04 8:39 ` Steven Scholz
2003-02-04 16:04 ` Tom Rini
2003-02-04 16:14 ` Steven Scholz
2003-02-04 19:32 ` Tom Rini
2003-02-04 19:55 ` Dan Malek
2003-02-07 7:35 ` Steven Scholz
2003-02-07 7:37 ` Steven Scholz [this message]
2003-02-07 17:12 ` Tom Rini
2003-02-07 17:15 ` Steven Scholz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E436221.8040903@imc-berlin.de \
--to=steven.scholz@imc-berlin.de \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).