GUARDED attribute not set by consistent

linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed

* GUARDED attribute not set by consistent_alloc()
@ 2003-02-07 15:07 Joakim Tjernlund
  2003-02-07 15:57 ` Dan Malek
  0 siblings, 1 reply; 2+ messages in thread
From: Joakim Tjernlund @ 2003-02-07 15:07 UTC (permalink / raw)
  To: Linuxppc-Embedded@Lists. Linuxppc. Org

Hi

While browsing the tree I noticed that consistent_alloc() does not
set the _PAGE_GUARDED attribute(only _PAGE_KERNEL and _PAGE_NO_CACHE)
on the allocated memory.

ioremap() adds _PAGE_GUARDED if _PAGE_NO_CACHE is set. Should not
consistent_alloc() also add _PAGE_GUARDED?

  Jocke

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: GUARDED attribute not set by consistent_alloc()
  2003-02-07 15:07 GUARDED attribute not set by consistent_alloc() Joakim Tjernlund
@ 2003-02-07 15:57 ` Dan Malek
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Malek @ 2003-02-07 15:57 UTC (permalink / raw)
  To: joakim.tjernlund; +Cc: Linuxppc-Embedded@Lists. Linuxppc. Org

Joakim Tjernlund wrote:

> ioremap() adds _PAGE_GUARDED if _PAGE_NO_CACHE is set. Should not
> consistent_alloc() also add _PAGE_GUARDED?

No.  ioremap() is used to map device registers, where operation
order is important.  consistent_alloc() maps real memory, where
setting guarded wouldn't change any behavior and would cost
significant pipeline drain cycles.

	-- Dan

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-02-07 15:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-02-07 15:07 GUARDED attribute not set by consistent_alloc() Joakim Tjernlund
2003-02-07 15:57 ` Dan Malek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).