From: Dan Malek <dan@embeddededge.com>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Jean-Denis Boyer <jdboyer@m5t.com>, linuxppc-embedded@lists.linuxppc.org
Subject: Re: PATCH: arch/ppc/8xx_io_fec.c
Date: Tue, 27 May 2003 15:33:52 -0400 [thread overview]
Message-ID: <3ED3BDA0.3030208@embeddededge.com> (raw)
In-Reply-To: 20030527165824.GG3453@ip68-0-152-218.tc.ph.cox.net
Tom Rini wrote:
> Dan, do you see any problems with this?
Yes. There are silicon revisions that require the FEC to
be enabled for the MDIO to operate. I don't remember if it was
listed in errata or in some of the early supplements. This code
change may work in this particular case, but I know it's required
for some parts. I have not looked at the detail of the patch
and the code it moves to see if this is done elsewhere.
The code formatting looks like crap, so that needs to be fixed.
It would be nice to hear from other people that have recently made
changes for specific board/PHY combinations to see if this patch
affects them.
Thanks.
-- Dan
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-05-27 19:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-27 14:38 PATCH: arch/ppc/8xx_io_fec.c Jean-Denis Boyer
2003-05-27 16:58 ` Tom Rini
2003-05-27 19:33 ` Dan Malek [this message]
2003-05-27 20:13 ` Tom Rini
2003-05-28 11:04 ` Dan Malek
-- strict thread matches above, loose matches on Subject: below --
2003-05-27 19:47 Jean-Denis Boyer
2003-05-28 11:01 ` Dan Malek
2003-05-28 13:57 Steven Rothweiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ED3BDA0.3030208@embeddededge.com \
--to=dan@embeddededge.com \
--cc=jdboyer@m5t.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).