From: Dan Malek <dan@embeddededge.com>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Jean-Denis Boyer <jdboyer@m5t.com>, linuxppc-embedded@lists.linuxppc.org
Subject: Re: PATCH: arch/ppc/8xx_io_fec.c
Date: Wed, 28 May 2003 07:04:54 -0400 [thread overview]
Message-ID: <3ED497D6.2070902@embeddededge.com> (raw)
In-Reply-To: 20030527201343.GM3453@ip68-0-152-218.tc.ph.cox.net
Tom Rini wrote:
> How would you suggest working around both this problem, and the problems
> that Jean-Denis reported?
I understand the problem that needed to be fixed, and that was done.
It seems quite a few people have been making changes do this driver,
logic has been copied around and some of it doesn't make sense.
In your usual, "send me lots of patches" mode, there should have been
one to fix the real problem, and another to do "clean up." :-)
>>The code formatting looks like crap, so that needs to be fixed.
>
>
> That's trivial 'tho. :)
If you have time to do it, that's fine. I don't :-)
Thanks.
-- Dan
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-05-28 11:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-27 14:38 PATCH: arch/ppc/8xx_io_fec.c Jean-Denis Boyer
2003-05-27 16:58 ` Tom Rini
2003-05-27 19:33 ` Dan Malek
2003-05-27 20:13 ` Tom Rini
2003-05-28 11:04 ` Dan Malek [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-05-27 19:47 Jean-Denis Boyer
2003-05-28 11:01 ` Dan Malek
2003-05-28 13:57 Steven Rothweiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ED497D6.2070902@embeddededge.com \
--to=dan@embeddededge.com \
--cc=jdboyer@m5t.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).