Tom Rini wrote:

>On Thu, Jun 05, 2003 at 02:47:46PM -0700, Mark A. Greer wrote:
>
>
>
>>@@ -416,14 +481,10 @@
>> 		ppc_md.progress("ev64260_setup_arch: Enabling L2 cache", 0);
>>
>> 	/* Enable L2 and L3 caches (if 745x) */
>>-	val = _get_L2CR();
>>-	val |= L2CR_L2E;
>>-	_set_L2CR(val);
>>-
>>-	if (PVR_VER(mfspr(PVR)) == PVR_VER(PVR_7450)) {
>>-		val = _get_L3CR();
>>-		val |= L3CR_L3E;
>>-		_set_L3CR(val);
>>+	_set_L2CR(_get_L2CR() | L2CR_L2E);
>>+
>>+	if (cur_cpu_spec[0]->cpu_features & CPU_FTR_L3CR) {
>>+		_set_L3CR(_get_L3CR() | L3CR_L3E);
>> 	}
>>
>> 	if ( ppc_md.progress )
>>
>>
>
>Redundant check.  _{get,set}_L3CR check for the appropriate cpufeature
>flags.
>
Gone.

>>@@ -808,7 +789,7 @@
>> {
>> 	extern char cmd_line[];
>>
>>-	cmd_line[0]=0;
>>+	cmd_line[0] = '\0';
>> #ifdef CONFIG_BLK_DEV_INITRD
>> 	initrd_start=initrd_end=0;
>> 	initrd_below_start_ok=0;
>>
>>
>
>Um, is that really needed?  It shouldn't be..
>
Nope.  Somehow, that line got injected into the code to I carried it
forward.  I won't anymore.  Its gone.

Attached is the new patch.

Mark