From: Kumar Gala <galak@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org, r61911@freescale.com,
"<shuo.liu@freesacle.com>" <shuo.liu@freesacle.com>,
Zhao Chenhui <b35336@freescale.com>
Subject: Re: [PATCH] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx
Date: Fri, 16 Mar 2012 16:03:10 -0500 [thread overview]
Message-ID: <3F0C165C-B018-4751-97FD-557C36FC40B6@kernel.crashing.org> (raw)
In-Reply-To: <4F63A5BD.1090207@freescale.com>
On Mar 16, 2012, at 3:42 PM, Scott Wood wrote:
> On 03/16/2012 03:35 PM, Kumar Gala wrote:
>> On Feb 10, 2012, at 2:09 AM, <shuo.liu@freesacle.com> =
<shuo.liu@freesacle.com> wrote:
>>> +static int is_in_pci_mem_space(phys_addr_t addr)
>>> +{
>>> + struct pci_controller *hose;
>>> + struct resource *res;
>>> + int i;
>>> +
>>> + list_for_each_entry(hose, &hose_list, list_node) {
>>> + for (i =3D 0; i < 3; i++) {
>>> + res =3D &hose->mem_resources[i];
>>> + if ((res->flags & IORESOURCE_MEM) &&
>>> + addr >=3D res->start && addr <=3D =
res->end)
>>> + return 1;
>>> + }
>>> + }
>>> + return 0;
>>=20
>> just move this into fsl_pci_mcheck_exception() no need for a separate =
function.
>=20
> A separate function increases readability.
>=20
> -Scott
I'll accept that.
- k=
next prev parent reply other threads:[~2012-03-16 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 8:09 [PATCH] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx shuo.liu
2012-03-16 20:35 ` Kumar Gala
2012-03-16 20:42 ` Scott Wood
2012-03-16 21:03 ` Kumar Gala [this message]
2012-03-16 21:03 ` Kumar Gala
2012-03-26 6:14 ` Jia Hongtao-B38951
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F0C165C-B018-4751-97FD-557C36FC40B6@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=b35336@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r61911@freescale.com \
--cc=scottwood@freescale.com \
--cc=shuo.liu@freesacle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).