From: Keshava Munegowda <keshava_mgowda@ti.com>
To: tmarri@apm.com, linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: greg@kroah.com
Subject: RE: [PATCH v10 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver
Date: Tue, 29 Mar 2011 16:28:43 +0530 [thread overview]
Message-ID: <3a04648a22d8cb5be414fe90b2bd0d84@mail.gmail.com> (raw)
In-Reply-To: <1301336856-1802-1-git-send-email-tmarri@apm.com>
> -----Original Message-----
> From: linux-usb-owner@vger.kernel.org
[mailto:linux-usb-owner@vger.kernel.org] On Behalf Of
> tmarri@apm.com
> Sent: Monday, March 28, 2011 11:58 PM
> To: linux-usb@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Cc: greg@kroah.com; tmarri@apm.com
> Subject: [PATCH v10 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver
>
> From: Tirumala Marri <tmarri@apm.com>
>
> v10:
> 1. Change address argument type from u32 to ulong to
> make it arch independent.
> 2. Cleaning un-necasary changes from Kconfig.
>
> v9:
> 1. Move the source under usb/otg/dwc.
> 2. Rename the source files with out dwc_otg prefix.
> 3. Remove unused read/write modify functions.
> 4. Including changes related to register base print.
>
> Tirumala Marri (10):
> USB/ppc4xx: Add Synopsys DWC OTG Register definitions
> USB/ppc4xx: Add Synopsys DWC OTG driver framework
> USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)
> USB/ppc4xx: Add Synopsys DWC OTG HCD function
> USB/ppc4xx: Add Synopsys DWC OTG HCD interrupt function
> USB/ppc4xx: Add Synopsys DWC OTG HCD queue function
> USB/ppc4xx: Add Synopsys DWC OTG PCD function
> USB ppc4xx: Add Synopsys DWC OTG PCD interrupt function
> USB/ppc4xx:Synopsys DWC OTG driver enable gadget support
> USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and
> Makefile
>
> drivers/Makefile | 1 +
> drivers/usb/Kconfig | 2 +
> drivers/usb/gadget/Kconfig | 22 +
> drivers/usb/gadget/gadget_chips.h | 9 +
> drivers/usb/otg/dwc/Kconfig | 88 ++
> drivers/usb/otg/dwc/Makefile | 19 +
> drivers/usb/otg/dwc/apmppc.c | 414 +++++++
> drivers/usb/otg/dwc/cil.c | 972 +++++++++++++++
> drivers/usb/otg/dwc/cil.h | 1177 ++++++++++++++++++
> drivers/usb/otg/dwc/cil_intr.c | 616 +++++++++
> drivers/usb/otg/dwc/driver.h | 76 ++
> drivers/usb/otg/dwc/hcd.c | 2465
+++++++++++++++++++++++++++++++++++++
> drivers/usb/otg/dwc/hcd.h | 416 +++++++
> drivers/usb/otg/dwc/hcd_intr.c | 1477 ++++++++++++++++++++++
> drivers/usb/otg/dwc/hcd_queue.c | 696 +++++++++++
> drivers/usb/otg/dwc/param.c | 180 +++
> drivers/usb/otg/dwc/pcd.c | 1766 ++++++++++++++++++++++++++
> drivers/usb/otg/dwc/pcd.h | 139 +++
> drivers/usb/otg/dwc/pcd_intr.c | 2311
++++++++++++++++++++++++++++++++++
> drivers/usb/otg/dwc/regs.h | 1326 ++++++++++++++++++++
> 20 files changed, 14172 insertions(+), 0 deletions(-)
> create mode 100644 drivers/usb/otg/dwc/Kconfig
> create mode 100644 drivers/usb/otg/dwc/Makefile
> create mode 100644 drivers/usb/otg/dwc/apmppc.c
> create mode 100644 drivers/usb/otg/dwc/cil.c
> create mode 100644 drivers/usb/otg/dwc/cil.h
> create mode 100644 drivers/usb/otg/dwc/cil_intr.c
> create mode 100644 drivers/usb/otg/dwc/driver.h
> create mode 100644 drivers/usb/otg/dwc/hcd.c
> create mode 100644 drivers/usb/otg/dwc/hcd.h
> create mode 100644 drivers/usb/otg/dwc/hcd_intr.c
> create mode 100644 drivers/usb/otg/dwc/hcd_queue.c
> create mode 100644 drivers/usb/otg/dwc/param.c
> create mode 100644 drivers/usb/otg/dwc/pcd.c
> create mode 100644 drivers/usb/otg/dwc/pcd.h
> create mode 100644 drivers/usb/otg/dwc/pcd_intr.c
> create mode 100644 drivers/usb/otg/dwc/regs.h
>
> --
Just a cosmetic review comment: you need to Tabify the declarations of in
the functions, at least when you are declaring variable of different data
types
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-03-29 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 18:27 [PATCH v10 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver tmarri
2011-03-29 10:58 ` Keshava Munegowda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a04648a22d8cb5be414fe90b2bd0d84@mail.gmail.com \
--to=keshava_mgowda@ti.com \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).