From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xR65T40tnzDqp8 for ; Tue, 8 Aug 2017 04:49:33 +1000 (AEST) Subject: Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() To: SF Markus Elfring , linuxppc-dev@lists.ozlabs.org Cc: Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , LKML , kernel-janitors@vger.kernel.org References: <8d140d00-935c-da0a-ff2e-167abe642bda@infradead.org> <32cdcd8a-1000-223c-71da-4c9119954d4e@users.sourceforge.net> From: Geoff Levand Message-ID: <3a657b44-2bc8-ee05-3a42-db7af354967e@infradead.org> Date: Mon, 7 Aug 2017 11:49:28 -0700 MIME-Version: 1.0 In-Reply-To: <32cdcd8a-1000-223c-71da-4c9119954d4e@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/07/2017 11:34 AM, SF Markus Elfring wrote: >> I didn't consider one would be triggered by the kzalloc failure. > > Do you reconsider any special system settings for further > software evolution then? Sorry, I don't quite understand your question. I think your original patch is OK, and I would appreciate if you added a check for failure of ps3vram_cache_init() in ps3vram_probe(). If you decide not to add that check I'll create a patch for it later. If this doesn't answer your question, could you please rephrase it? -Geoff