linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Linas Vepstas <linasvepstas@gmail.com>
To: leitao@linux.vnet.ibm.com
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] eeh: Fixing a bug when pci structure is null
Date: Wed, 27 Jan 2010 13:09:53 -0600	[thread overview]
Message-ID: <3ae3aa421001271109s6b857384x7617566220ffc38b@mail.gmail.com> (raw)
In-Reply-To: <0642ead63df1b9fdced24750eb0aea940f0408b7.1264617281.git.root@sanx1002.austin.ibm.com>

Hi,

Yes, that's really my sign off: I discussed this at length with Breno.
One comment:

2010/1/27  <leitao@linux.vnet.ibm.com>:
> During a EEH recover, the pci_dev structure can be null,

It can be null when an error is detected during device config (i.e. via
pci config space access through open firmware, using the OF device
node, instead of mmio/dma access), before the kernel has created
a pci_dev structure for the device.

Oddly enough, either this slipped through the cracks all this time,
or maybe pci_name() used to protect against nulls? Not sure.

-- Linas Vepstas

  parent reply	other threads:[~2010-01-27 19:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27 18:43 [PATCH 1/2] eeh: Fixing a bug when pci structure is null leitao
2010-01-27 18:43 ` [PATCH 2/2] eeh: fixing pci_dev dependency leitao
2010-01-29  0:04   ` Benjamin Herrenschmidt
2010-01-29 15:42     ` Linas Vepstas
2010-01-27 19:09 ` Linas Vepstas [this message]
2010-01-29  0:03 ` [PATCH 1/2] eeh: Fixing a bug when pci structure is null Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ae3aa421001271109s6b857384x7617566220ffc38b@mail.gmail.com \
    --to=linasvepstas@gmail.com \
    --cc=leitao@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).