From: Linas Vepstas <linasvepstas@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, leitao@linux.vnet.ibm.com
Subject: Re: [PATCH 2/2] eeh: fixing pci_dev dependency
Date: Fri, 29 Jan 2010 09:42:04 -0600 [thread overview]
Message-ID: <3ae3aa421001290742i7768cb79gf0684758dbe85a0d@mail.gmail.com> (raw)
In-Reply-To: <1264723487.20211.17.camel@pasglop>
On 28 January 2010 18:04, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Wed, 2010-01-27 at 12:43 -0600, leitao@linux.vnet.ibm.com wrote:
>> Currently pci_dev can be null when EEH is in action. This patch
>> just assure that we pci_dev is not NULL before calling pci_dev_put.
>
> Like all variants of *_put(), it already checks for a NULL argument
> afaik. So that patch should be unnecessary.
Ah, OK, I paniced when I saw that and assumed the worst
--linas
next prev parent reply other threads:[~2010-01-29 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 18:43 [PATCH 1/2] eeh: Fixing a bug when pci structure is null leitao
2010-01-27 18:43 ` [PATCH 2/2] eeh: fixing pci_dev dependency leitao
2010-01-29 0:04 ` Benjamin Herrenschmidt
2010-01-29 15:42 ` Linas Vepstas [this message]
2010-01-27 19:09 ` [PATCH 1/2] eeh: Fixing a bug when pci structure is null Linas Vepstas
2010-01-29 0:03 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ae3aa421001290742i7768cb79gf0684758dbe85a0d@mail.gmail.com \
--to=linasvepstas@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=leitao@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).