linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
	Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	linuxppc-dev@lists.ozlabs.org
Cc: clombard@linux.vnet.ibm.com, vaibhav@linux.vnet.ibm.com,
	fbarrat@linux.vnet.ibm.com, imunsie@au1.ibm.com,
	felix@linux.vnet.ibm.com
Subject: Re: [PATCH] cxl: add option to enable -DDEBUG
Date: Mon, 18 Jul 2016 08:54:05 -0500	[thread overview]
Message-ID: <3b6b37ab-f146-73ee-6b32-b9d63a52eac5@linux.vnet.ibm.com> (raw)
In-Reply-To: <877fcjb4rm.fsf@@concordia.ellerman.id.au>



On 7/18/2016 5:49 AM, Michael Ellerman wrote:
> Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:
>
>> Developers working on AFUs and AFU drivers often find it useful to see the
>> pr_devel() and dev_dbg() messages from cxl. Give them an easy way to enable
>> -DDEBUG by adding a Kconfig option, CONFIG_CXL_DEBUG.
>
> Another option is to use DYNAMIC_DEBUG. If you turn that on the
> dev_dbg()'s can be enabled at runtime, and you could en masse or
> selectively convert the pr_devel()s to pr_debug() to get the same
> result.
>
> cheers
>

Andrew, DYNAMIC_DEBUG would be more useful for us because it can be 
enabled at runtime just like we do for cxlflash.

      reply	other threads:[~2016-07-18 13:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18  8:17 [PATCH] cxl: add option to enable -DDEBUG Andrew Donnellan
2016-07-18  8:19 ` Ian Munsie
2016-07-18 10:49 ` Michael Ellerman
2016-07-18 13:54   ` Uma Krishnan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b6b37ab-f146-73ee-6b32-b9d63a52eac5@linux.vnet.ibm.com \
    --to=ukrishn@linux.vnet.ibm.com \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=clombard@linux.vnet.ibm.com \
    --cc=fbarrat@linux.vnet.ibm.com \
    --cc=felix@linux.vnet.ibm.com \
    --cc=imunsie@au1.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=vaibhav@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).