From: Randy Dunlap <rdunlap@infradead.org>
To: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
linux-doc@vger.kernel.org, virtualization@lists.linux.dev,
"Andrew Morton" <akpm@linux-foundation.org>,
"Oscar Salvador" <osalvador@suse.de>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Mike Rapoport" <rppt@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Michal Hocko" <mhocko@suse.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jerrin Shaji George" <jerrin.shaji-george@broadcom.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>, "Zi Yan" <ziy@nvidia.com>
Subject: Re: [PATCH v1 20/23] mm/kconfig: make BALLOON_COMPACTION depend on MIGRATION
Date: Tue, 21 Oct 2025 10:13:33 -0700 [thread overview]
Message-ID: <3ba11b0c-818f-41d5-8885-038c7e0133f5@infradead.org> (raw)
In-Reply-To: <20251021150040.498160-4-david@redhat.com>
On 10/21/25 8:00 AM, David Hildenbrand wrote:
> Migration support for balloon memory depends on MIGRATION not
> COMPACTION. Compaction is simply another user of page migration.
>
> The last dependency on compaction.c was effectively removed with
> commit 3d388584d599 ("mm: convert "movable" flag in page->mapping to a
> page flag"). Ever since, everything for handling movable_ops page
> migration resides in core migration code.
>
> So let's change the dependency and adjust the description +
> help text.
>
> We'll rename BALLOON_COMPACTION separately next.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> mm/Kconfig | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index e47321051d765..3aff4d05a2d8c 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -599,17 +599,14 @@ config MEMORY_BALLOON
> #
> # support for memory balloon compaction
> config BALLOON_COMPACTION
> - bool "Allow for balloon memory compaction/migration"
> + bool "Allow for balloon memory migration"
> default y
> - depends on COMPACTION && MEMORY_BALLOON
> - help
> - Memory fragmentation introduced by ballooning might reduce
> - significantly the number of 2MB contiguous memory blocks that can be
> - used within a guest, thus imposing performance penalties associated
> - with the reduced number of transparent huge pages that could be used
> - by the guest workload. Allowing the compaction & migration for memory
> - pages enlisted as being part of memory balloon devices avoids the
> - scenario aforementioned and helps improving memory defragmentation.
> + depends on MIGRATION && MEMORY_BALLOON
> + help
> + Allow for migration of pages inflated in a memory balloon such that
> + they can be allocated from memory areas only available for movable
> + allocations (e.g., ZONE_MOVABLE, CMA) and such that they can get
nit:
s/get/be/
> + migrated for memory defragmentation purposes by memory compaction.
>
> #
> # support for memory compaction
--
~Randy
next prev parent reply other threads:[~2025-10-21 17:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 12:59 [PATCH v1 00/23] mm: balloon infrastructure cleanups David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 01/23] vmw_balloon: adjust BALLOON_DEFLATE when deflating while migrating David Hildenbrand
2025-10-22 1:03 ` SeongJae Park
2025-10-21 12:59 ` [PATCH v1 02/23] vmw_balloon: remove vmballoon_compaction_init() David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 03/23] powerpc/pseries/cmm: remove cmm_balloon_compaction_init() David Hildenbrand
2025-10-21 20:43 ` Michael S. Tsirkin
2025-10-22 8:37 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 04/23] mm/balloon_compaction: centralize basic page migration handling David Hildenbrand
2025-10-21 20:50 ` Michael S. Tsirkin
2025-10-22 8:37 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 05/23] mm/balloon_compaction: centralize adjust_managed_page_count() handling David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 06/23] vmw_balloon: stop using the balloon_dev_info lock David Hildenbrand
2025-10-21 20:57 ` Michael S. Tsirkin
2025-10-22 8:40 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 07/23] mm/balloon_compaction: use a device-independent balloon (list) lock David Hildenbrand
2025-10-21 20:52 ` Michael S. Tsirkin
2025-10-22 8:42 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 08/23] mm/balloon_compaction: remove dependency on page lock David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 09/23] mm/balloon_compaction: make balloon_mops static David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 10/23] mm/balloon_compaction: drop fs.h include from balloon_compaction.h David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 11/23] drivers/virtio/virtio_balloon: stop using balloon_page_push/pop() David Hildenbrand
2025-10-21 20:59 ` Michael S. Tsirkin
2025-10-22 8:43 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 12/23] mm/balloon_compaction: remove balloon_page_push/pop() David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 13/23] mm/balloon_compaction: fold balloon_mapping_gfp_mask() into balloon_page_alloc() David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 14/23] mm/balloon_compaction: move internal helpers to memory_compaction.c David Hildenbrand
2025-10-21 15:36 ` Zi Yan
2025-10-21 15:37 ` David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 15/23] mm/balloon_compaction: assert that the balloon_pages_lock is held David Hildenbrand
2025-10-21 12:59 ` [PATCH v1 16/23] mm/balloon_compaction: mark remaining functions for having proper kerneldoc David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 17/23] mm/balloon_compaction: remove "extern" from functions David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 18/23] mm/vmscan: drop inclusion of balloon_compaction.h David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 19/23] mm: rename balloon_compaction.(c|h) to balloon.(c|h) David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 20/23] mm/kconfig: make BALLOON_COMPACTION depend on MIGRATION David Hildenbrand
2025-10-21 17:13 ` Randy Dunlap [this message]
2025-10-21 18:43 ` David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 21/23] mm: rename CONFIG_BALLOON_COMPACTION to CONFIG_BALLOON_MIGRATION David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 22/23] mm: rename CONFIG_MEMORY_BALLOON -> CONFIG_BALLOON David Hildenbrand
2025-10-21 15:00 ` [PATCH v1 23/23] MAINTAINERS: move memory balloon infrastructure to "MEMORY MANAGEMENT - BALLOON" David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba11b0c-818f-41d5-8885-038c7e0133f5@infradead.org \
--to=rdunlap@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=eperezma@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=jerrin.shaji-george@broadcom.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maddy@linux.ibm.com \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).