From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03A5CD637A6 for ; Wed, 13 Nov 2024 18:45:35 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XpXKV3N9Tz2yh1; Thu, 14 Nov 2024 05:45:34 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1731523534; cv=none; b=Zez29jhs8hQLE3fbrPrG/mwfycIXa37xnoA8SwxQPtN1DhAevNMI2q9Z4egoGt2xlLWwFkwQklhzl4piXEAyM4eOR/+A4ggjhqBbtpiL/ReAAYgX4POHDplKcuriOmOIvRPJ7kZuEclpbV/OHLSR7nnVxbdPdFsEw7auwg2q6KKiS1L5gEir/EQ+n9+3lWShxKYcn9MPpQevFvng4EjrcW7HD9IUNkJsWSOb+RL96zQz7TDVUCR9/bw52GM9yp2Syv+niCnYQypRY+2DH6+iVSVLGXro1SDOXqzqGNALmi+iEilsOfwCKHgHikXe44rAuHfWqFsgjaawrW5UB7bmSA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1731523534; c=relaxed/relaxed; bh=oiRy7tMpXqzMBxF0V5M1vZe3r1wcdUHw4HgsZMbQH2Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aR2jKdYte401rL0iU7IMhXi9Siee+g4ytwbE0rAG0LmmM4sp2oooAsTMh2p3Orsjo8ZPCwrH07pZeiR41uAI76DxF7gSPo17cDv91yIdT3mqe2pS1XlGHFz4ZDUxol0UF3yv/yh2lWJzg0W4H1vZrRQj5oUmZaAehy529f0bqYuHTItd3rBc+tm7FMBjzJdJBlyOGmwvuQZ3UZ5eoiS2WtSrBneTfD9A23FV6tL0fkTRsaiDMtuoGYLlYiqfyLnuOBw1XEf6n2obh7dqyrZHWR6aD4FJ8kCtFC1msYKu1mGRi6/xNt25mU+w24LZ6PYDPdMRFZwxF+7NsZ4kHFhOqA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QItJuSDv; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QItJuSDv; dkim-atps=neutral; spf=pass (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) smtp.mailfrom=redhat.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QItJuSDv; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QItJuSDv; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4XpXKT0mFBz2yKD for ; Thu, 14 Nov 2024 05:45:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731523526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oiRy7tMpXqzMBxF0V5M1vZe3r1wcdUHw4HgsZMbQH2Q=; b=QItJuSDvG0vJbFkNM5niv2FCV/MNC1rhDSzdZ6GVtbXk2O9iH8P/oXmVlJhvDIuUSTxhxg vH9DditRSuv4O+FFMVIu9WpOX8a5Afl17/tq35pU1pBKbTjSJaC2XNbE0zGwV+8djTcgJy dhkcKHQSFCQ3V2eaKcWMFz2++IJvcpc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731523526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oiRy7tMpXqzMBxF0V5M1vZe3r1wcdUHw4HgsZMbQH2Q=; b=QItJuSDvG0vJbFkNM5niv2FCV/MNC1rhDSzdZ6GVtbXk2O9iH8P/oXmVlJhvDIuUSTxhxg vH9DditRSuv4O+FFMVIu9WpOX8a5Afl17/tq35pU1pBKbTjSJaC2XNbE0zGwV+8djTcgJy dhkcKHQSFCQ3V2eaKcWMFz2++IJvcpc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-gV8jt-CWNW6yTnsw8iRkOQ-1; Wed, 13 Nov 2024 13:45:24 -0500 X-MC-Unique: gV8jt-CWNW6yTnsw8iRkOQ-1 X-Mimecast-MFC-AGG-ID: gV8jt-CWNW6yTnsw8iRkOQ Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43151e4ef43so50140705e9.3 for ; Wed, 13 Nov 2024 10:45:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731523523; x=1732128323; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=oiRy7tMpXqzMBxF0V5M1vZe3r1wcdUHw4HgsZMbQH2Q=; b=NebHfekkdQkEBjfVM6uf0XRJV9ifxvgH7fEBgUFYKX+rblHtvc6EjpwSITUEX1KoCJ 2c/s06f2PAMj53whI+lItWIXLRyD6mN64NsQpDK49r1VfUo1QAU+mGktv1p/0cx9wXOw n6mV1c2ua0SyYZ63/wPM83sO9njUP0TiCU7EbX4ZEfsZaOiy+InJXMMa6cLrmT9YMu4x QJfgFpURLgcDRjSVmRTK+UrsWignSY+uFmerXbTo6wegyJhDeAI1JiPch700N0VqiPCP ebTjVgM+Uj9dQio2Sj88jH0/iiHIoBjUdnhjhS4yqu4n7FFZGDfrDIlNQAEtcSn/L/r3 31UA== X-Forwarded-Encrypted: i=1; AJvYcCVcYr2GqfLWLTJ9yUN194W0dRQ1J/VFaE03MeHJAHaBaqSsa4fyQUG/eSVvzPGzgAhPiAauK6zsB+R5mtQ=@lists.ozlabs.org X-Gm-Message-State: AOJu0YzeLUTkaOYEIs27ZB1GOA909CEZRfZ6hQgttLf+0Y9IZMehFkGG yKefCZUVz5n2XBh5dIHE7OezbhYJc5JCQEipLuWMU6uVRUWdCWsc9IuMmdXoqcQgcXq8j8g3kkA jWAq5biYDkHyGEUTiHs7HnfwqatrNVE2kkUc7TuLevnUeR6aW7lh7TymuU3Ez35s= X-Received: by 2002:a05:600c:c08:b0:42c:bd27:4c12 with SMTP id 5b1f17b1804b1-432d4aae6b7mr42155585e9.10.1731523523055; Wed, 13 Nov 2024 10:45:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdMZHL+YKk/qd9EVqmBiiyqPXnVJueSChXwtWqIhdBqK0IgMFXLo997Jor7MXgVsm2UQyemg== X-Received: by 2002:a05:600c:c08:b0:42c:bd27:4c12 with SMTP id 5b1f17b1804b1-432d4aae6b7mr42154585e9.10.1731523521172; Wed, 13 Nov 2024 10:45:21 -0800 (PST) Received: from ?IPV6:2003:cb:c708:1500:d584:7ad8:d3f7:5539? (p200300cbc7081500d5847ad8d3f75539.dip0.t-ipconnect.de. [2003:cb:c708:1500:d584:7ad8:d3f7:5539]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432d54e2e0esm34971275e9.2.2024.11.13.10.45.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Nov 2024 10:45:20 -0800 (PST) Message-ID: <3ceb9fc6-47cd-4715-ab86-517ed873dc04@redhat.com> Date: Wed, 13 Nov 2024 19:45:19 +0100 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/7] mm/mprotect: Fix dax puds To: Peter Xu Cc: Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Kirill A . Shutemov" , Nicholas Piggin , Matthew Wilcox , Andrew Morton , James Houghton , Huang Ying , "Aneesh Kumar K . V" , Vlastimil Babka , Rick P Edgecombe , Hugh Dickins , Borislav Petkov , Christophe Leroy , Michael Ellerman , Rik van Riel , Dan Williams , Mel Gorman , x86@kernel.org, Ingo Molnar , linuxppc-dev@lists.ozlabs.org, Dave Hansen , Dave Jiang , Oscar Salvador , Thomas Gleixner References: <20240812181225.1360970-1-peterx@redhat.com> <07ba2a86-f22b-43aa-a542-f1a182656b63@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9ZuSWUlctzgb3hWjy4D8-SuN0pSe9Q0ALqGDHoxVz1Y_1731523523 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13.11.24 18:56, Peter Xu wrote: > On Wed, Nov 13, 2024 at 05:42:15PM +0100, David Hildenbrand wrote: >> On 13.11.24 17:39, Peter Xu wrote: >>> On Mon, Nov 11, 2024 at 10:20:59PM +0100, Jann Horn wrote: >>>> On Mon, Aug 12, 2024 at 8:12 PM Peter Xu wrote: >>>>> Dax supports pud pages for a while, but mprotect on puds was missing since >>>>> the start. This series tries to fix that by providing pud handling in >>>>> mprotect(). The goal is to add more types of pud mappings like hugetlb or >>>>> pfnmaps. This series paves way for it by fixing known pud entries. >>>> >>>> Do people actually use hardware where they can use PUD THP mappings >>>> for DAX? I thought that was just some esoteric feature that isn't >>>> actually usable on almost any system. >>>> Was I wrong about that? >>> >>> I did run it with a qemu emulated nvdimm device. Though in reality I've no >>> idea on how many people are using it.. >> >> I wonder if we still have to support it ... or could disable it+rip it out. > > Note that in my previous email, I also mentioned mremap() for PMD on dax > too. If that's a real problem, it won't be fixed even if dropping dax PUD > support. > Very true. > And we definitely want to understand whether there're still users on pud > dax to consider dropping anything.. it could still be that both mprotect() > and mremap() are not yet used in the current use cases. Right, but at least NVDIMMs are getting less important. Just a thought if this is really still worth having. -- Cheers, David / dhildenb