From: Russell Currey <ruscur@russell.cc>
To: Benjamin Gray <bgray@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: npiggin@gmail.com
Subject: Re: [PATCH v2 10/12] selftests/powerpc: Add more utility macros
Date: Mon, 08 May 2023 14:43:14 +1000 [thread overview]
Message-ID: <3e0792f3c7d30cdfec36466a013af6ced8f6d33b.camel@russell.cc> (raw)
In-Reply-To: <20230330055040.434133-11-bgray@linux.ibm.com>
On Thu, 2023-03-30 at 16:50 +1100, Benjamin Gray wrote:
> * Include unistd.h for _exit()
> * Include stdio.h for fprintf()
> * Adds _MSG assertion variants to provide more context behind why a
> failure occurred.
> * Move ARRAY_SIZE macro to utils.h
>
> The _MSG variants and ARRAY_SIZE will be used by the following
> DEXCR selftests.
>
> Signed-off-by: Benjamin Gray <bgray@linux.ibm.com>
>
I'd prefer if your commit message led with adding FAIL_IF_MSG etc and
then mentioned the other changes to support it. It's unintuitive to
read as-is.
Reviewed-by: Russell Currey <ruscur@russell.cc>
next prev parent reply other threads:[~2023-05-08 4:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 5:50 [PATCH v2 00/12] Add static DEXCR support Benjamin Gray
2023-03-30 5:50 ` [PATCH v2 01/12] powerpc/book3s: Add missing <linux/sched.h> include Benjamin Gray
2023-05-08 3:36 ` Russell Currey
2023-03-30 5:50 ` [PATCH v2 02/12] powerpc/ptrace: Add missing <linux/regset.h> include Benjamin Gray
2023-05-08 3:39 ` Russell Currey
2023-03-30 5:50 ` [PATCH v2 03/12] powerpc/dexcr: Add initial Dynamic Execution Control Register (DEXCR) support Benjamin Gray
2023-05-08 3:44 ` Russell Currey
2023-03-30 5:50 ` [PATCH v2 04/12] powerpc/dexcr: Handle hashchk exception Benjamin Gray
2023-05-08 4:00 ` Russell Currey
2023-03-30 5:50 ` [PATCH v2 05/12] powerpc/dexcr: Support userspace ROP protection Benjamin Gray
2023-05-08 4:10 ` Russell Currey
2023-03-30 5:50 ` [PATCH v2 06/12] powerpc/dexcr: Support custom default DEXCR value Benjamin Gray
2023-05-08 4:24 ` Russell Currey
2023-03-30 5:50 ` [PATCH v2 07/12] powerpc/ptrace: Expose DEXCR and HDEXCR registers to ptrace Benjamin Gray
2023-05-08 4:30 ` Russell Currey
2023-03-30 5:50 ` [PATCH v2 08/12] powerpc/ptrace: Expose HASHKEYR register " Benjamin Gray
2023-05-08 4:32 ` Russell Currey
2023-03-30 5:50 ` [PATCH v2 09/12] Documentation: Document PowerPC kernel DEXCR interface Benjamin Gray
2023-05-08 4:40 ` Russell Currey
2023-03-30 5:50 ` [PATCH v2 10/12] selftests/powerpc: Add more utility macros Benjamin Gray
2023-05-08 4:43 ` Russell Currey [this message]
2023-03-30 5:50 ` [PATCH v2 11/12] selftests/powerpc/dexcr: Add hashst/hashchk test Benjamin Gray
2023-03-30 5:50 ` [PATCH v2 12/12] selftests/powerpc/dexcr: Add DEXCR status utility lsdexcr Benjamin Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e0792f3c7d30cdfec36466a013af6ced8f6d33b.camel@russell.cc \
--to=ruscur@russell.cc \
--cc=bgray@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).