From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muin.pair.com (muin.pair.com [209.68.1.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yzXkr6dLXzDsN5 for ; Sun, 17 Dec 2017 03:27:13 +1100 (AEDT) Subject: Re: [PATCH v3 03/11] ASoC: fsl_ssi: Refine all comments To: Nicolin Chen Cc: Mark Brown , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, fabio.estevam@nxp.com, mail@maciej.szmigiero.name, caleb@crome.org, lgirdwood@gmail.com, arnaud.mouiche@invoxia.com, lukma@denx.de, kernel@pengutronix.de References: <1513207108-30430-1-git-send-email-nicoleotsuka@gmail.com> <1513207108-30430-4-git-send-email-nicoleotsuka@gmail.com> From: Timur Tabi Message-ID: <3ee01787-9c38-6780-b247-b7d81769e53e@tabi.org> Date: Sat, 16 Dec 2017 10:27:06 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/16/17 12:10 AM, Nicolin Chen wrote: > Hi, > > I am outside so can't use mutt. Sorry for that. > > This comment is going to be replaced in the 2nd set anyway because the > whole function will be replaced. So you're asking me to review comment changes that will soon be deleted? Can you send out a new patch without changes to comments, so that I can focus on the ones that matter? > And please point out all comments that you think I need to rework. I am > totally fine to do that. I don't think every single one is bad. And this > patch has to go in as it also adds a lot of new comments. Ok.