From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0CF9EB64D7 for ; Fri, 23 Jun 2023 21:44:05 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=gXVVIt50; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QnrNN064cz3bsP for ; Sat, 24 Jun 2023 07:44:04 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=gXVVIt50; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=adityag@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Qnlhf6zRrz30hG for ; Sat, 24 Jun 2023 04:12:50 +1000 (AEST) Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35NICF8f026357; Fri, 23 Jun 2023 18:12:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=content-type : message-id : date : subject : to : cc : references : from : in-reply-to : mime-version; s=pp1; bh=6/tP7bKLcNhXEGZJvwFjMs8JssxYDz1puBoFb7YidTE=; b=gXVVIt50OvAMXcSBmH4psmL8dmiZExqcHcCsM+ljvcgRkYyxgOR/s9PxTH0X6E0XONBh yT1AY84EjBWE4/kHVJQSUFcTAA65SqngMeUHMA8iO20S0IV0t4PKvjKwTQuv0sih3akj e0a8bRVHZaut0SrmFXcjO7aochH82x33ha4ozi5T/kmFl5pjvvUg6A2/0RoWAv+zROlX W44tRFVfSV+HMMmCPbefpeicDos3qHoiJk+lNKJW7oiKsb6Bfkutps9pPDYkTnwmWg+H NUf62TpMolzLjYSYfXPbQk15P5c/LQHWDxrDOSqoAYONxuk0VO2MpIvFvEk1mMRF6A8e kg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rdg39rf71-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jun 2023 18:12:31 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35NICUnM028375; Fri, 23 Jun 2023 18:12:30 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rdg39rev2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jun 2023 18:12:21 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35N15jEO030018; Fri, 23 Jun 2023 18:08:30 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3r943e4b9q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jun 2023 18:08:30 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35NI8Qve20447778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Jun 2023 18:08:26 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A708C20040; Fri, 23 Jun 2023 18:08:26 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7CCBD20043; Fri, 23 Jun 2023 18:08:23 +0000 (GMT) Received: from [9.43.112.194] (unknown [9.43.112.194]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 23 Jun 2023 18:08:23 +0000 (GMT) Content-Type: multipart/alternative; boundary="------------F210A2iXnlaQFK1MBAi2K9Mp" Message-ID: <3f0debdc-7fcc-11aa-c798-c32e9f371af0@linux.ibm.com> Date: Fri, 23 Jun 2023 23:38:22 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 15/17] perf tests task_analyzer: fix bad substitution ${$1} Content-Language: en-IN, en-US To: Namhyung Kim References: <20230613164145.50488-1-atrajeev@linux.vnet.ibm.com> <20230613164145.50488-16-atrajeev@linux.vnet.ibm.com> <5ab5cc25-03b0-ef7f-3dc0-be1b59a4147d@linux.ibm.com> From: Aditya Gupta In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: fj4SXbK18el5twjuQw6p2o11nwAZ6FZl X-Proofpoint-ORIG-GUID: MajqSMgspfQsiZvax9wLnVhi3HI9-C_C X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-23_10,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxlogscore=755 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306230161 X-Mailman-Approved-At: Sat, 24 Jun 2023 07:40:38 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: irogers@google.com, Athira Rajeev , john.g.garry@oracle.com, kjain@linux.ibm.com, ravi.bangoria@amd.com, Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org, Hagen Paul Pfeifer , maddy@linux.ibm.com, jolsa@kernel.org, disgoel@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" This is a multi-part message in MIME format. --------------F210A2iXnlaQFK1MBAi2K9Mp Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Namhyung, On 23/06/23 04:55, Namhyung Kim wrote: > Ok, I found two problems. > > ... > The first one is related to this message. It couldn't find the script > (task-analyzer.py) because PERF_EXEC_PATH is not set. > Running with --exec-path=$PWD was ok, but I got a segfault. > > The other problem is in set_regs_in_dict(). It tries to capture > register values in the sample and save them to a dictionary. > The sample doesn't have registers so it should have no problem. > But the 'bf' was not initialized properly when size is 0, and it led > PyUnicode_FromString() returning NULL. > > After the changes, it ran ok: > > $ sudo ./perf test -v task > 116: perf script task-analyzer tests : > --- start --- > test child forked, pid 204088 > PASS: "test_basic" > PASS: "test_ns_rename" > PASS: "test_ms_filtertasks_highlight" > PASS: "test_extended_times_timelimit_limittasks" > PASS: "test_summary" > PASS: "test_summaryextended" > PASS: "test_summaryonly" > PASS: "test_extended_times_summary_ns" > PASS: "test_extended_times_summary_ns" > PASS: "test_csv" > PASS: "test_csvsummary" > PASS: "test_csv_extended_times" > PASS: "test_csvsummary_extended" > test child finished with 0 > ---- end ---- > perf script task-analyzer tests: Ok > This is interesting. I did not encounter these earlier. > I'll send the fixes soon. > Thanks for fixing it. >> You can try the perf-tools-next branch in the perf/perft-tools-next.git repo. >> >> git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git >> >> $ make clean all >> $ sudo ./perf test -v task >> I tested with the steps provided, i.e.. clone, /*apply patch 15 (added this step myself)*/, clean, make, ./perf test -v test. But still- test passed: ''' ~/temp_clones/perf-tools-next/tools/perf git:(master) sudo ./perf test -v test ... --- start --- test child forked, pid 75261 PASS: "test_basic" PASS: "test_ns_rename" PASS: "test_ms_filtertasks_highlight" PASS: "test_extended_times_timelimit_limittasks" PASS: "test_summary" PASS: "test_summaryextended" PASS: "test_summaryonly" PASS: "test_extended_times_summary_ns" PASS: "test_extended_times_summary_ns" PASS: "test_csv" PASS: "test_csvsummary" PASS: "test_csv_extended_times" PASS: "test_csvsummary_extended" test child finished with 0 ---- end ---- ''' Maybe my environment had that other things set in such a way that, I did not face any issue (I don't recall doing so though, and these patches have been tested multiple times by more people also). But thanks, that you debugged this and fixed the issue also, I was unsure of the reason since I did not encounter it. Thanks, - AdityaG --------------F210A2iXnlaQFK1MBAi2K9Mp Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit 
Hello Namhyung,


On 23/06/23 04:55, Namhyung Kim wrote:
Ok, I found two problems.

...

The first one is related to this message.  It couldn't find the script
(task-analyzer.py) because PERF_EXEC_PATH is not set.
Running with --exec-path=$PWD was ok, but I got a segfault.

The other problem is in set_regs_in_dict().  It tries to capture
register values in the sample and save them to a dictionary.
The sample doesn't have registers so it should have no problem.
But the 'bf' was not initialized properly when size is 0, and it led
PyUnicode_FromString() returning NULL.

After the changes, it ran ok:

$ sudo ./perf test -v task
116: perf script task-analyzer tests                                 :
--- start ---
test child forked, pid 204088
PASS: "test_basic"
PASS: "test_ns_rename"
PASS: "test_ms_filtertasks_highlight"
PASS: "test_extended_times_timelimit_limittasks"
PASS: "test_summary"
PASS: "test_summaryextended"
PASS: "test_summaryonly"
PASS: "test_extended_times_summary_ns"
PASS: "test_extended_times_summary_ns"
PASS: "test_csv"
PASS: "test_csvsummary"
PASS: "test_csv_extended_times"
PASS: "test_csvsummary_extended"
test child finished with 0
---- end ----
perf script task-analyzer tests: Ok


This is interesting. I did not encounter these earlier.


I'll send the fixes soon.


Thanks for fixing it.


You can try the perf-tools-next branch in the perf/perft-tools-next.git repo.

  git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git

  $ make clean all
  $ sudo ./perf test -v task


I tested with the steps provided, i.e.. clone, /*apply patch 15 (added this step myself)*/, clean, make, ./perf test -v test. But still- test passed:

'''
~/temp_clones/perf-tools-next/tools/perf git:(master) sudo ./perf test -v test

...

--- start ---
test child forked, pid 75261
PASS: "test_basic"
PASS: "test_ns_rename"
PASS: "test_ms_filtertasks_highlight"
PASS: "test_extended_times_timelimit_limittasks"
PASS: "test_summary"
PASS: "test_summaryextended"
PASS: "test_summaryonly"
PASS: "test_extended_times_summary_ns"
PASS: "test_extended_times_summary_ns"
PASS: "test_csv"
PASS: "test_csvsummary"
PASS: "test_csv_extended_times"
PASS: "test_csvsummary_extended"
test child finished with 0
---- end ----
'''


Maybe my environment had that other things set in such a way that, I did not face any issue (I don't recall doing so though, and these patches have been tested multiple times by more people also).
But thanks, that you debugged this and fixed the issue also, I was unsure of the reason since I did not encounter it.


Thanks,
- AdityaG
--------------F210A2iXnlaQFK1MBAi2K9Mp--