linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Frank Rowand <frowand.list@gmail.com>
To: Alan Tull <atull@kernel.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	linux-fpga@vger.kernel.org,
	Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Moritz Fischer <mdf@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 05.1/16] of:overlay: missing name, phandle, linux, phandle in new nodes
Date: Thu, 11 Oct 2018 16:38:26 -0700	[thread overview]
Message-ID: <3f36468b-676a-558d-4180-7129d2bf2c6c@gmail.com> (raw)
In-Reply-To: <CANk1AXSRifmwu1FQRY_hsuqDESEzcMET_hpLNZOeW4QLrUwsdw@mail.gmail.com>

On 10/11/18 12:33, Alan Tull wrote:
> On Thu, Oct 11, 2018 at 12:39 AM Frank Rowand <frowand.list@gmail.com> wrote:
> 
> [resend of my messed up rejected email of a minute ago, sorry]
> 
>>
>> On 10/10/18 14:03, Frank Rowand wrote:

< snip >

> I understand you're quite busy with all this, but I'm wondering
> whether it might be worth it go ahead and make the properties be
> kernel objects also at this point.  That would be an improvement for
> the case of overlay properties added to non-overlay nodes, so the
> lifespan of the overlay property memory can be coupled with the
> properties kobj's instead of the node kobj's.
> 
> Alan
> 

That is one of the approaches that I am thinking about to handle
the potential memory leaks from those properties.

I'd like to make these changes in a step wise fashion, to let each
major change get some exposure and use before moving on to the
next step.  Making properties into kernel objects would impact
a lot of code.

So not in this series.  But thanks for thinking about it.

-Frank

  reply	other threads:[~2018-10-11 23:41 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05  4:12 [PATCH 00/16] of: overlay: validation checks, subsequent fixes frowand.list
2018-10-05  4:12 ` [PATCH 01/16] of: overlay: add tests to validate kfrees from overlay removal frowand.list
2018-10-05  4:12 ` [PATCH 02/16] of: overlay: add missing of_node_put() after add new node to changeset frowand.list
2018-10-05  4:12 ` [PATCH 03/16] of: overlay: add missing of_node_get() in __of_attach_node_sysfs frowand.list
2018-10-05  4:12 ` [PATCH 04/16] powerpc/pseries: add of_node_put() in dlpar_detach_node() frowand.list
2018-10-05  4:12 ` [PATCH 05/16] of: overlay: use prop add changeset entry for property in new nodes frowand.list
2018-10-09 20:28   ` Alan Tull
2018-10-09 23:44     ` Frank Rowand
2018-10-10  6:04     ` [PATCH 05.1/16] of:overlay: missing name, phandle, linux, phandle " frowand.list
2018-10-10  6:49       ` Frank Rowand
2018-10-10 20:40         ` Alan Tull
2018-10-10 21:03           ` Frank Rowand
2018-10-11  5:39             ` Frank Rowand
2018-10-11 19:33               ` Alan Tull
2018-10-11 23:38                 ` Frank Rowand [this message]
2018-10-05  4:12 ` [PATCH 06/16] of: overlay: do not duplicate properties from overlay for " frowand.list
2018-10-05  4:12 ` [PATCH 07/16] of: dynamic: change type of of_{at, de}tach_node() to void frowand.list
2018-10-05  4:12 ` [PATCH 08/16] of: overlay: reorder fields in struct fragment frowand.list
2018-10-05  4:12 ` [PATCH 09/16] of: overlay: validate overlay properties #address-cells and #size-cells frowand.list
2018-10-05 15:07   ` Rob Herring
2018-10-05 18:53     ` Frank Rowand
2018-10-05 19:04       ` Rob Herring
2018-10-05 19:09         ` Frank Rowand
2018-10-08 15:57   ` Alan Tull
2018-10-08 18:46     ` Alan Tull
2018-10-09  0:02       ` Frank Rowand
2018-10-09 18:40         ` Alan Tull
2018-10-05  4:12 ` [PATCH 10/16] of: overlay: make all pr_debug() and pr_err() messages unique frowand.list
2018-10-05  4:12 ` [PATCH 11/16] of: overlay: test case of two fragments adding same node frowand.list
2018-10-05  4:12 ` [PATCH 12/16] of: overlay: check prevents multiple fragments add or delete " frowand.list
2018-10-05  4:12 ` [PATCH 13/16] of: overlay: check prevents multiple fragments touching same property frowand.list
2018-10-05  4:12 ` [PATCH 14/16] of: unittest: remove unused of_unittest_apply_overlay() argument frowand.list
2018-10-05  4:12 ` [PATCH 15/16] of: unittest: initialize args before calling of_irq_parse_one() frowand.list
2018-10-05 13:26   ` Guenter Roeck
2018-10-05 19:05     ` Frank Rowand
2018-10-05 14:53   ` Rob Herring
2018-10-05 19:04     ` Frank Rowand
2018-10-05  4:12 ` [PATCH 16/16] of: unittest: find overlays[] entry by name instead of index frowand.list

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f36468b-676a-558d-4180-7129d2bf2c6c@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=atull@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mdf@kernel.org \
    --cc=pantelis.antoniou@konsulko.com \
    --cc=paulus@samba.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).