From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE212C25B75 for ; Tue, 4 Jun 2024 02:01:27 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=bnlgXxEM; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VtYjf0bmnz3dRZ for ; Tue, 4 Jun 2024 12:01:26 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=bnlgXxEM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=dlemoal@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VtY1S3yR2z3dJ9 for ; Tue, 4 Jun 2024 11:30:04 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DFC22611CC; Tue, 4 Jun 2024 01:30:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79DCCC2BD10; Tue, 4 Jun 2024 01:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717464601; bh=+0MwbPrNLjHstEP7nUmI9nU5cr+C1uEqCmU+IfVJhBs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bnlgXxEMpTvmKahSPWzVW2eioXzJ7InXnLcF2Rs1JSkMfQA93wXQBY9/XKuZVVXJi oeHmsD31IY3HyHMYtTD7PSrvj9S1H3KP04TKlWZzgFGXGWPDdoy6u+l15hTWpd+gzW rrkqErwJ5iAh1ROObeeg8gEUmGPLn4HkWiomXClAUEV1Ygn9FUP+Qbw+IPeT8+Ws56 I8+zq8Wdj1Ege6tKvptsdljRUJrjovlC8dK+XkPQEaDh/6yi5A2iz8Lc911AkK3iVQ 9J/Qo4EvtrUegklsv+qidHqtelitfCS46Jvgeoe5elf4+5tozjA1SGSUxdf7rn2IsA VjsM2fsbxxo3g== Message-ID: <3f98a7da-19c8-4e91-94d7-e8256cc0cb1e@kernel.org> Date: Tue, 4 Jun 2024 10:29:35 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string() To: Andy Shevchenko , "Rafael J. Wysocki" , Greg Kroah-Hartman , Corey Minyard , Allen Pais , Sebastian Reichel , Perry Yuan , Giovanni Cabiddu , Herbert Xu , Nuno Sa , Guenter Roeck , Randy Dunlap , Andi Shyti , Heiner Kallweit , Lee Jones , Samuel Holland , Elad Nachman , Arseniy Krasnov , Johannes Berg , Gregory Greenman , Benjamin Berg , Bjorn Helgaas , Robert Richter , Vinod Koul , Chunfeng Yun , Linus Walleij , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Nikita Kravets , Jiri Slaby , Srinivas Pandruvada , Stanley Chang , Heikki Krogerus , Abdel Alkuor , Kent Overstreet , Eric Biggers , Kees Cook , Ingo Molnar , "Steven Rostedt (Google)" , Daniel Bristot de Oliveira , Andrew Morton , Hugh Dickins , Abel Wu , John Johansen , Mimi Zohar , Stefan Berger , Roberto Sassu , Eric Snowberg , Takashi Iwai , Takashi Sakamoto , Jiapeng Chong , Mark Brown , Kuninori Morimoto , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-acpi@vger.kernel.org, linux-ide@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, qat-linux@intel.com, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org, linux-leds@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-staging@lists.linux.dev, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-hardening@vger.kernel.org, cgroups@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org References: <20240603211538.289765-1-andriy.shevchenko@linux.intel.com> From: Damien Le Moal Content-Language: en-US Organization: Western Digital Research In-Reply-To: <20240603211538.289765-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 04 Jun 2024 12:00:46 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Andrew Lunn , Prashant Gaikwad , Heiko Stuebner , "Rafael J. Wysocki" , Viresh Kumar , Jaroslav Kysela , Ben Segall , Pavel Machek , Miquel Raynal , Kishon Vijay Abraham I , Vincent Guittot , James Morris , Tvrtko Ursulin , Danilo Krummrich , Mel Gorman , Jean Delvare , Potnuri Bharat Teja , Nicholas Piggin , Thomas Gleixner , Zhihao Cheng , Dietmar Eggemann , Scott Branden , Dmitry Kasatkin , Mahesh J Salgaonkar , Masami Hiramatsu , " Gautham R. Shenoy" , Tejun Heo , Linus Torvalds , Lukasz Luba , Zefan Li , Dave Hansen , Clemens Ladisch , Liam Girdwood , Hu Ziji , Eric Dumazet , Thierry Reding , Oliver O'Halloran , Mario Limonciello , Valentin Schneider , Paul Moore , Gregory Clement , Daniel Lezcano , Jonathan Hunter , Len Brown , Brian Foster , Maxime Ripard , Jason Baron , Jani Nikula , Stephen Boyd , Daniel Bristot de Oliveira , Miri Korenblit , Ulf Hansson , Karol Herbst , Alexander Shishkin , Michael Turquette , Joonas Lahtinen , Jernej Skrabec , Peter Zijlstra , Chen-Yu Tsai , Broadcom internal kernel review list , "Naveen N. Rao" , Paolo Abeni , "Serge E. Hallyn" , Lyude Paul , Ray Jui , Borislav Petkov , Rodrigo Vivi , Sergey Shtylyov , Thinh Nguyen , Sebastian Reichel , Daniel Scally , JC Kuo , Sakari Ailus , "David S. Miller" , Vignesh Raghavendra , Tony L indgren , Takashi Iwai , David Howells , Niklas Cassel , Huang Rui , "H. Peter Anvin" , David Airlie , Jim Cromie , Florian Fainelli , Richard Weinberger , x86@kernel.org, Ingo Molnar , Jakub Kicinski , Zhang Rui , Sebastian Hesselbarth , Thomas Zimmermann , Kalle Valo , Maarten Lankhorst , Matthias Brugger , AngeloGioacchino Del Regno , Peter De Schrijver , Adrian Hunter , Daniel Vetter , Johannes Weiner , Mathieu Desnoyers , Helge Deller Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 6/3/24 00:57, Andy Shevchenko wrote: > Make two APIs look similar. Hence convert match_string() to be > a 2-argument macro. In order to avoid unneeded churn, convert > all users as well. There is no functional change intended. > > Signed-off-by: Andy Shevchenko > --- [...] > diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c > index bdccd1ba1524..8134f9290791 100644 > --- a/drivers/ata/pata_hpt366.c > +++ b/drivers/ata/pata_hpt366.c > @@ -178,7 +178,7 @@ static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr, > > ata_id_c_string(dev->id, model_num, ATA_ID_PROD, sizeof(model_num)); > > - i = match_string(list, -1, model_num); > + i = __match_string(list, -1, model_num); > if (i >= 0) { > ata_dev_warn(dev, "%s is not supported for %s\n", modestr, list[i]); > return 1; > diff --git a/drivers/ata/pata_hpt37x.c b/drivers/ata/pata_hpt37x.c > index c0329cf01135..2d0b659bbd65 100644 > --- a/drivers/ata/pata_hpt37x.c > +++ b/drivers/ata/pata_hpt37x.c > @@ -226,7 +226,7 @@ static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr, > > ata_id_c_string(dev->id, model_num, ATA_ID_PROD, sizeof(model_num)); > > - i = match_string(list, -1, model_num); > + i = __match_string(list, -1, model_num); > if (i >= 0) { > ata_dev_warn(dev, "%s is not supported for %s\n", > modestr, list[i]); Looks good to me. Acked-by: Damien Le Moal # drivers/ata/ -- Damien Le Moal Western Digital Research