From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3r4CYc4CrRzDq5s for ; Wed, 11 May 2016 07:48:36 +1000 (AEST) In-Reply-To: <1462254105-24128-2-git-send-email-gwshan@linux.vnet.ibm.com> To: Gavin Shan , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: aik@ozlabs.ru, alistair@popple.id.au, Gavin Shan Subject: Re: [v9,01/26] powerpc/pci: Cleanup on struct pci_controller_ops Message-Id: <3r4CYc3G14z9t45@ozlabs.org> Date: Wed, 11 May 2016 07:48:36 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2016-03-05 at 05:41:20 UTC, Gavin Shan wrote: > Each PHB has one instance of "struct pci_controller_ops" that includes > various callbacks called by PCI subsystem. In the definition of this > struct, some callbacks have explicit names for its arguments, but the > left don't have. > > This adds all explicit names of the arguments to the callbacks in > "struct pci_controller_ops" so that the code looks consistent. Also, > argument name @dev is replaced by @pdev as the later one is the > preferred name for PCI device. > > Signed-off-by: Gavin Shan > Reviewed-by: Daniel Axtens > Reviewed-by: Andrew Donnellan > Reviewed-by: Alexey Kardashevskiy Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/ec73f9a8dfdfce0112ee041705 cheers