From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rrTty3n6lzDqyc for ; Fri, 15 Jul 2016 20:53:14 +1000 (AEST) In-Reply-To: <1468444634-1866-7-git-send-email-imunsie@au.ibm.com> To: Ian Munsie , Michael Neuling , Frederic Barrat , Andrew Donnellan , linuxppc-dev@lists.ozlabs.org, Huy Nguyen From: Michael Ellerman Cc: Ian Munsie Subject: Re: [06/15] cxl: Do not create vPHB if there are no AFU configuration records Message-Id: <3rrTty1hxzz9snm@ozlabs.org> Date: Fri, 15 Jul 2016 20:53:14 +1000 (AEST) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2016-13-07 at 21:17:05 UTC, Ian Munsie wrote: > From: Ian Munsie > > The vPHB model of the cxl kernel API is a hierarchy where the AFU is > represented by the vPHB, and it's AFU configuration records are exposed > as functions under that vPHB. If there are no AFU configuration records > we will create a vPHB with nothing under it, which is a waste of > resources and will opt us into EEH handling despite not having anything > special to handle. > > This also does not make sense for cards using the peer model of the cxl > kernel API, where the other functions of the device are exposed via > additional peer physical functions rather than AFU configuration > records. This model will also not work with the existing EEH handling in > the cxl driver, as that is designed around the vPHB model. > > Skip creating the vPHB for AFUs without any AFU configuration records, > and opt out of EEH handling for them. > > Signed-off-by: Ian Munsie > Reviewed-by: Andrew Donnellan Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/e4f5fc001a6cb82bef91037245 cheers